Skip to content

Commit 2fd959b

Browse files
authored
[receiver/jmx] unexport InsertDefault (open-telemetry#43965)
1 parent 99a7c4a commit 2fd959b

File tree

2 files changed

+30
-3
lines changed

2 files changed

+30
-3
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# Use this changelog template to create an entry for release notes.
2+
3+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
4+
change_type: breaking
5+
6+
# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
7+
component: receiver/jmx
8+
9+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
10+
note: unexport InsertDefault
11+
12+
# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
13+
issues: [43965]
14+
15+
# (Optional) One or more lines of additional information to render under the primary note.
16+
# These lines will be padded with 2 spaces and then inserted directly into the document.
17+
# Use pipe (|) for multiline entries.
18+
subtext:
19+
20+
# If your change doesn't affect end users or the exported elements of any package,
21+
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
22+
# Optional: The change log or logs in which this entry should be included.
23+
# e.g. '[user]' or '[user, api]'
24+
# Include 'user' if the change is relevant to end users.
25+
# Include 'api' if there is a change to a library API.
26+
# Default: '[user]'
27+
change_logs: [api]

receiver/jmxreceiver/receiver.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,8 +134,8 @@ func (jmx *jmxMetricReceiver) Shutdown(ctx context.Context) error {
134134
return removeErr
135135
}
136136

137-
// InsertDefault is a helper function to insert a default value for a configoptional.Optional type.
138-
func InsertDefault[T any](opt *configoptional.Optional[T]) error {
137+
// insertDefault is a helper function to insert a default value for a configoptional.Optional type.
138+
func insertDefault[T any](opt *configoptional.Optional[T]) error {
139139
if opt.HasValue() {
140140
return nil
141141
}
@@ -168,7 +168,7 @@ func (jmx *jmxMetricReceiver) buildOTLPReceiver() (receiver.Metrics, error) {
168168

169169
factory := otlpreceiver.NewFactory()
170170
config := factory.CreateDefaultConfig().(*otlpreceiver.Config)
171-
if err := InsertDefault(&config.GRPC); err != nil {
171+
if err := insertDefault(&config.GRPC); err != nil {
172172
return nil, err
173173
}
174174
config.GRPC.Get().NetAddr = confignet.AddrConfig{Endpoint: endpoint, Transport: confignet.TransportTypeTCP}

0 commit comments

Comments
 (0)