[chore] pdata/pprofile: remove field Profile.StartTime (open-telemetry#41074)

This is the supporting change for
open-telemetry/opentelemetry-collector#13315
where Profile.StartTime gets removed.

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Florian Lehner <[email protected]>

Author: florianl

extension/encoding/otlpencodingextension/extension_test.go

@@ -202,7 +202,7 @@ func generateProfiles() pprofile.Profiles {
 	for i := 0; i < num; i++ {
 		im := ilm.Profiles().AppendEmpty()
 		im.SetProfileID([16]byte{0x01, 0x02, 0x03, 0x04})
-		im.SetStartTime(pcommon.NewTimestampFromTime(now))
+		im.SetTime(pcommon.NewTimestampFromTime(now))
 		im.SetDuration(pcommon.NewTimestampFromTime(time.Now()))
 	}
 	return pd

internal/coreinternal/testdata/profile.go

@@ -49,7 +49,7 @@ func GenerateProfilesTwoProfilesSameResource() pprofile.Profiles {
 }
 
 func fillProfileOne(dic pprofile.ProfilesDictionary, profile pprofile.Profile) {
-	profile.SetStartTime(TestProfileStartTimestamp)
+	profile.SetTime(TestProfileStartTimestamp)
 	profile.SetProfileID([16]byte{0x01, 0x02, 0x03, 0x04})
 
 	profile.AttributeIndices().Append(0)
@@ -63,7 +63,7 @@ func fillProfileOne(dic pprofile.ProfilesDictionary, profile pprofile.Profile) {
 }
 
 func fillProfileTwo(dic pprofile.ProfilesDictionary, profile pprofile.Profile) {
-	profile.SetStartTime(TestProfileStartTimestamp)
+	profile.SetTime(TestProfileStartTimestamp)
 	profile.SetProfileID([16]byte{0x05, 0x06, 0x07, 0x08})
 
 	profile.AttributeIndices().Append(0)

pkg/pdatatest/pprofiletest/options.go

@@ -128,7 +128,7 @@ func (opt ignoreProfileTimestampValues) maskProfileTimestampValues(profiles ppro
 			lrs := sls.At(j).Profiles()
 			for k := 0; k < lrs.Len(); k++ {
 				lr := lrs.At(k)
-				lr.SetStartTime(pcommon.NewTimestampFromTime(time.Time{}))
+				lr.SetTime(pcommon.NewTimestampFromTime(time.Time{}))
 				lr.SetDuration(pcommon.NewTimestampFromTime(time.Time{}))
 			}
 		}
@@ -188,8 +188,8 @@ func sortProfileSlices(ls pprofile.Profiles) {
 	for i := 0; i < ls.ResourceProfiles().Len(); i++ {
 		for j := 0; j < ls.ResourceProfiles().At(i).ScopeProfiles().Len(); j++ {
 			ls.ResourceProfiles().At(i).ScopeProfiles().At(j).Profiles().Sort(func(a, b pprofile.Profile) bool {
-				if a.StartTime() != b.StartTime() {
-					return a.StartTime() < b.StartTime()
+				if a.Time() != b.Time() {
+					return a.Time() < b.Time()
 				}
 				if a.Duration() != b.Duration() {
 					return a.Duration() < b.Duration()

pkg/pdatatest/pprofiletest/profiles.go

@@ -252,10 +252,6 @@ func CompareProfile(expectedDic, actualDic pprofile.ProfilesDictionary, expected
 		errs = multierr.Append(errs, fmt.Errorf("profileID does not match expected '%s', actual '%s'", expected.ProfileID().String(), actual.ProfileID().String()))
 	}
 
-	if expected.StartTime() != actual.StartTime() {
-		errs = multierr.Append(errs, fmt.Errorf("start timestamp doesn't match expected: %d, "+"actual: %d", expected.StartTime(), actual.StartTime()))
-	}
-
 	if !reflect.DeepEqual(expected.LocationIndices(), actual.LocationIndices()) {
 		errs = multierr.Append(errs, errors.New("locationIndicies do not match expected"))
 	}
@@ -276,10 +272,6 @@ func CompareProfile(expectedDic, actualDic pprofile.ProfilesDictionary, expected
 		errs = multierr.Append(errs, fmt.Errorf("keepFrames does not match expected '%s', actual '%s'", expected.OriginalPayload().AsRaw(), actual.OriginalPayload().AsRaw()))
 	}
 
-	if expected.StartTime() != actual.StartTime() {
-		errs = multierr.Append(errs, fmt.Errorf("startTime doesn't match expected: %d, actual: %d", expected.StartTime(), actual.StartTime()))
-	}
-
 	if expected.Duration() != actual.Duration() {
 		errs = multierr.Append(errs, fmt.Errorf("duration doesn't match expected: %d, actual: %d", expected.Duration(), actual.Duration()))
 	}

pkg/pdatatest/pprofiletest/profiles_test.go

@@ -327,7 +327,7 @@ func TestCompareProfiles(t *testing.T) {
 				}
 				return p.Transform()
 			}(),
-			withoutOptions: errors.New(`resource "map[key1:value1]": scope "scope1": profile "map[container-attr1:value1]": start timestamp doesn't match expected: 1577836800000000000, actual: 1577836805000000000; resource "map[key1:value1]": scope "scope1": profile "map[container-attr1:value1]": time doesn't match expected: 1577836800000000000, actual: 1577836805000000000; resource "map[key1:value1]": scope "scope1": profile "map[container-attr1:value1]": startTime doesn't match expected: 1577836800000000000, actual: 1577836805000000000`),
+			withoutOptions: errors.New(`resource "map[key1:value1]": scope "scope1": profile "map[container-attr1:value1]": time doesn't match expected: 1577836800000000000, actual: 1577836805000000000`),
 			compareOptions: []CompareProfilesOption{
 				IgnoreProfileTimestampValues(),
 			},