[*/datadog] Move datadogconnector functionality into pkg/datadog (open-telemetry#43980)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

Replaces open-telemetry#43755

Refactor datadog modules in order to expose NewConnectorFactoryForAgent
method that datadog-agent repo will import to instantiate
datadogconnector in DDOT.

Also fix a bug in connector.

Author: IbraheemA

.chloggen/connector-dont-bail-on-downstream-error.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: connector/datadog
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Datadog connector no longer stalls after a downstream component errors
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [43980]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

.chloggen/ibraheem_move-ddconnector-into-pkg.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: pkg/datadog
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Expose NewConnectorFactory method to instantiate the Datadog connector with injected dependencies.
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [43980]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [api]

connector/datadogconnector/benchmark_test.go

@@ -18,6 +18,11 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector/internal/metadata"
 )
 
+var (
+	testTraceID = [16]byte{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16}
+	testSpanID1 = [8]byte{1, 2, 3, 4, 5, 6, 7, 8}
+)
+
 func genTrace() ptrace.Traces {
 	start := time.Now().Add(-1 * time.Second)
 	end := time.Now()
@@ -40,11 +45,7 @@ func genTrace() ptrace.Traces {
 	return traces
 }
 
-func BenchmarkPeerTags_Native(b *testing.B) {
-	benchmarkPeerTags(b)
-}
-
-func benchmarkPeerTags(b *testing.B) {
+func BenchmarkPeerTags(b *testing.B) {
 	cfg := NewFactory().CreateDefaultConfig().(*Config)
 	cfg.Traces.ComputeStatsBySpanKind = true
 	cfg.Traces.PeerTagsAggregation = true

connector/datadogconnector/config.go

@@ -4,8 +4,6 @@
 package datadogconnector // import "github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector"
 
 import (
-	"errors"
-
 	"go.opentelemetry.io/collector/component"
 
 	datadogconfig "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/config"
@@ -14,17 +12,4 @@ import (
 var _ component.Config = (*Config)(nil)
 
 // Config defines configuration for the Datadog connector.
-type Config struct {
-	// Traces defines the Traces specific configuration
-	Traces datadogconfig.TracesConnectorConfig `mapstructure:"traces"`
-	// prevent unkeyed literal initialization
-	_ struct{}
-}
-
-// Validate checks if the configuration is valid
-func (c *Config) Validate() error {
-	if c.Traces.IgnoreMissingDatadogFields {
-		return errors.New("ignore_missing_datadog_fields is not yet supported in the connector")
-	}
-	return c.Traces.Validate()
-}
+type Config = datadogconfig.ConnectorComponentConfig

connector/datadogconnector/factory.go

@@ -6,17 +6,11 @@
 package datadogconnector // import "github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector"
 
 import (
-	"context"
-	"time"
-
-	"github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient"
-	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/connector"
-	"go.opentelemetry.io/collector/consumer"
 	"go.opentelemetry.io/collector/featuregate"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/connector/datadogconnector/internal/metadata"
-	datadogconfig "github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/config"
+	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog/apmstats"
 )
 
 const nativeIngestFeatureGateName = "connector.datadogconnector.NativeIngest"
@@ -30,46 +24,8 @@ var NativeIngestFeatureGate = featuregate.GlobalRegistry().MustRegister(
 	featuregate.WithRegisterToVersion("v0.143.0"),
 )
 
-// NewFactory creates a factory for tailtracer connector.
+// NewFactory creates a factory for datadog connector.
 func NewFactory() connector.Factory {
 	//  OTel connector factory to make a factory for connectors
-	return connector.NewFactory(
-		metadata.Type,
-		createDefaultConfig,
-		connector.WithTracesToMetrics(createTracesToMetricsConnector, metadata.TracesToMetricsStability),
-		connector.WithTracesToTraces(createTracesToTracesConnector, metadata.TracesToTracesStability))
-}
-
-func createDefaultConfig() component.Config {
-	return &Config{
-		Traces: datadogconfig.TracesConnectorConfig{
-			TracesConfig: datadogconfig.TracesConfig{
-				IgnoreResources:        []string{},
-				PeerServiceAggregation: true,
-				PeerTagsAggregation:    true,
-				ComputeStatsBySpanKind: true,
-			},
-
-			TraceBuffer:    1000,
-			BucketInterval: 10 * time.Second,
-		},
-	}
-}
-
-// defines the consumer type of the connector
-// we want to consume traces and export metrics therefore define nextConsumer as metrics, consumer is the next component in the pipeline
-func createTracesToMetricsConnector(_ context.Context, params connector.Settings, cfg component.Config, nextConsumer consumer.Metrics) (c connector.Traces, err error) {
-	metricsClient, err := metricsclient.InitializeMetricClient(params.MeterProvider, metricsclient.ConnectorSourceTag)
-	if err != nil {
-		return nil, err
-	}
-	c, err = newTraceToMetricConnectorNative(params.TelemetrySettings, cfg, nextConsumer, metricsClient)
-	if err != nil {
-		return nil, err
-	}
-	return c, nil
-}
-
-func createTracesToTracesConnector(_ context.Context, params connector.Settings, _ component.Config, nextConsumer consumer.Traces) (connector.Traces, error) {
-	return newTraceToTraceConnector(params.Logger, nextConsumer), nil
+	return apmstats.NewConnectorFactory(metadata.Type, metadata.TracesToMetricsStability, metadata.TracesToTracesStability, nil, nil, nil)
 }

connector/datadogconnector/go.mod

@@ -3,15 +3,6 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/connector/datad
 go 1.24.0
 
 require (
-	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient v0.73.0-rc.2
-	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/statsprocessor v0.73.0-rc.2
-	github.com/DataDog/datadog-agent/pkg/obfuscate v0.73.0-rc.2
-	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/otlp/attributes v0.73.0-rc.2
-	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/otlp/metrics v0.73.0-rc.2
-	github.com/DataDog/datadog-agent/pkg/proto v0.73.0-rc.2
-	github.com/DataDog/datadog-agent/pkg/trace v0.73.0-rc.2
-	github.com/DataDog/datadog-go/v5 v5.8.1
-	github.com/google/go-cmp v0.7.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter v0.139.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/datadog v0.139.0
 	github.com/open-telemetry/opentelemetry-collector-contrib/processor/tailsamplingprocessor v0.139.0
@@ -34,10 +25,6 @@ require (
 	go.opentelemetry.io/collector/processor/batchprocessor v0.139.1-0.20251105131800-09a271914bdc
 	go.opentelemetry.io/collector/receiver v1.45.1-0.20251105131800-09a271914bdc
 	go.opentelemetry.io/collector/receiver/otlpreceiver v0.139.1-0.20251105131800-09a271914bdc
-	go.opentelemetry.io/otel v1.38.0
-	go.opentelemetry.io/otel/metric v1.38.0
-	go.uber.org/zap v1.27.0
-	google.golang.org/protobuf v1.36.10
 )
 
 require (
@@ -65,6 +52,7 @@ require (
 	github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/serializerexporter v0.73.0-rc.2 // indirect
+	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/serializer/logscompression v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/serializer/metricscompression v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/trace/compression/def v0.73.0-rc.2 // indirect
@@ -95,18 +83,23 @@ require (
 	github.com/DataDog/datadog-agent/pkg/logs/status/utils v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/logs/types v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/metrics v0.73.0-rc.2 // indirect
+	github.com/DataDog/datadog-agent/pkg/obfuscate v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/inframetadata v0.73.0-rc.2 // indirect
+	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/otlp/attributes v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/otlp/logs v0.73.0-rc.2 // indirect
+	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/otlp/metrics v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/opentelemetry-mapping-go/otlp/rum v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/orchestrator/model v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/process/util/api v0.73.0-rc.2 // indirect
+	github.com/DataDog/datadog-agent/pkg/proto v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/remoteconfig/state v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/serializer v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/status/health v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/tagger/types v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/tagset v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/telemetry v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/template v0.73.0-rc.2 // indirect
+	github.com/DataDog/datadog-agent/pkg/trace v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/util/backoff v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/util/buf v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/util/cgroups v0.73.0-rc.2 // indirect
@@ -132,6 +125,7 @@ require (
 	github.com/DataDog/datadog-agent/pkg/util/winutil v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/pkg/version v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-api-client-go/v2 v2.49.0 // indirect
+	github.com/DataDog/datadog-go/v5 v5.8.1 // indirect
 	github.com/DataDog/go-sqllexer v0.1.9 // indirect
 	github.com/DataDog/go-tuf v1.1.1-0.5.2 // indirect
 	github.com/DataDog/gohai v0.0.0-20230524154621-4316413895ee // indirect
@@ -192,6 +186,7 @@ require (
 	github.com/golang/protobuf v1.5.4 // indirect
 	github.com/golang/snappy v1.0.0 // indirect
 	github.com/google/gnostic-models v0.7.0 // indirect
+	github.com/google/go-cmp v0.7.0 // indirect
 	github.com/google/go-tpm v0.9.6 // indirect
 	github.com/google/uuid v1.6.0 // indirect
 	github.com/gorilla/mux v1.8.1 // indirect
@@ -321,6 +316,7 @@ require (
 	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 // indirect
 	go.opentelemetry.io/contrib/otelconf v0.18.0 // indirect
 	go.opentelemetry.io/contrib/propagators/b3 v1.38.0 // indirect
+	go.opentelemetry.io/otel v1.38.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc v0.14.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp v0.14.0 // indirect
 	go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc v1.38.0 // indirect
@@ -333,6 +329,7 @@ require (
 	go.opentelemetry.io/otel/exporters/stdout/stdoutmetric v1.38.0 // indirect
 	go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.38.0 // indirect
 	go.opentelemetry.io/otel/log v0.14.0 // indirect
+	go.opentelemetry.io/otel/metric v1.38.0 // indirect
 	go.opentelemetry.io/otel/sdk v1.38.0 // indirect
 	go.opentelemetry.io/otel/sdk/log v0.14.0 // indirect
 	go.opentelemetry.io/otel/sdk/metric v1.38.0 // indirect
@@ -342,6 +339,7 @@ require (
 	go.uber.org/dig v1.19.0 // indirect
 	go.uber.org/fx v1.24.0 // indirect
 	go.uber.org/multierr v1.11.0 // indirect
+	go.uber.org/zap v1.27.0 // indirect
 	go.yaml.in/yaml/v2 v2.4.3 // indirect
 	go.yaml.in/yaml/v3 v3.0.4 // indirect
 	golang.org/x/crypto v0.43.0 // indirect
@@ -357,6 +355,7 @@ require (
 	google.golang.org/genproto/googleapis/api v0.0.0-20250825161204-c5933d9347a5 // indirect
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20250929231259-57b25ae835d4 // indirect
 	google.golang.org/grpc v1.76.0 // indirect
+	google.golang.org/protobuf v1.36.10 // indirect
 	gopkg.in/evanphx/json-patch.v4 v4.12.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/ini.v1 v1.67.0 // indirect

connector/datadogconnector/go.sum

@@ -63,7 +63,6 @@ require (
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/serializerexporter v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient v0.73.0-rc.2 // indirect
-	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/statsprocessor v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/serializer/logscompression v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/serializer/metricscompression v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/trace/compression/def v0.73.0-rc.2 // indirect

exporter/datadogexporter/integrationtest/go.mod

@@ -62,7 +62,6 @@ require (
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/serializerexporter v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/metricsclient v0.73.0-rc.2 // indirect
-	github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/statsprocessor v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/serializer/logscompression v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/serializer/metricscompression v0.73.0-rc.2 // indirect
 	github.com/DataDog/datadog-agent/comp/trace/compression/def v0.73.0-rc.2 // indirect