You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[chore] [receiver/webhookevent] Fix Good request with gzip test in webhookeventreceiver (open-telemetry#43874)
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This test ostensibly tests that a request sent with gzip is accepted by
the receiver, however because there's no mechanism to return back from
the receiver what log was actually parsed, it was missed that this
doesn't actually excercise the gzip flow.
In particular the test:
- Doesn't close the writer, which can result in invalid gzip streams
- Doesn't set the Content-Encoding on the request, so the receiver never
realises it's meant to use gzip anyway
As a result, this test was passing, but the "log" produced was a
meaningless truncated gzip stream. This fixes the test to actually
exercise the flow (which, thankfully, is working).
Signed-off-by: sinkingpoint <[email protected]>
0 commit comments