renaming 'cache' to be 'metricCache' so its more meaningful

Author: sv-splunk

receiver/sqlserverreceiver/factory.go

@@ -24,7 +24,7 @@ import (
 
 var errConfigNotSQLServer = errors.New("config was not a sqlserver receiver config")
 
-// newCache creates a new cache with the given size.
+// newCache creates a new metricCache with the given size.
 // If the size is less or equal to 0, it will be set to 1.
 // It will never return an error.
 func newCache(size int) *lru.Cache[string, int64] {
@@ -131,7 +131,7 @@ func setupSQLServerScrapers(params receiver.Settings, cfg *Config) []*sqlServerS
 		id := component.NewIDWithName(metadata.Type, fmt.Sprintf("query-%d: %s", i, query))
 
 		// lru only returns error when the size is less than 0
-		cache := newCache(1)
+		metricCache := newCache(1)
 		planCache, _ := lru.New[string, string](1)
 
 		sqlServerScraper := newSQLServerScraper(id, query,
@@ -140,7 +140,7 @@ func setupSQLServerScrapers(params receiver.Settings, cfg *Config) []*sqlServerS
 			sqlquery.NewDbClient,
 			params,
 			cfg,
-			cache,
+			metricCache,
 			planCache)
 
 		scrapers = append(scrapers, sqlServerScraper)

receiver/sqlserverreceiver/scraper.go

@@ -61,7 +61,7 @@ type sqlServerScraperHelper struct {
 	db                     *sql.DB
 	mb                     *metadata.MetricsBuilder
 	lb                     *metadata.LogsBuilder
-	cache                  *lru.Cache[string, int64]
+	metricCache            *lru.Cache[string, int64]
 	planCache              *lru.Cache[string, string]
 	lastExecutionTimestamp time.Time
 	obfuscator             *obfuscator
@@ -80,7 +80,7 @@ func newSQLServerScraper(id component.ID,
 	clientProviderFunc sqlquery.ClientProviderFunc,
 	params receiver.Settings,
 	cfg *Config,
-	cache *lru.Cache[string, int64],
+	metricCache *lru.Cache[string, int64],
 	planCache *lru.Cache[string, string],
 ) *sqlServerScraperHelper {
 	// Compute service instance ID
@@ -100,7 +100,7 @@ func newSQLServerScraper(id component.ID,
 		clientProviderFunc:     clientProviderFunc,
 		mb:                     metadata.NewMetricsBuilder(cfg.MetricsBuilderConfig, params),
 		lb:                     metadata.NewLogsBuilder(cfg.LogsBuilderConfig, params),
-		cache:                  cache,
+		metricCache:            metricCache,
 		planCache:              planCache,
 		lastExecutionTimestamp: time.Unix(0, 0),
 		obfuscator:             newObfuscator(),
@@ -830,14 +830,14 @@ func (s *sqlServerScraperHelper) cacheAndDiff(queryHash, queryPlanHash, column s
 
 	key := queryHash + "-" + queryPlanHash + "-" + column
 
-	cached, ok := s.cache.Get(key)
+	cached, ok := s.metricCache.Get(key)
 	if !ok {
-		s.cache.Add(key, val)
+		s.metricCache.Add(key, val)
 		return false, val
 	}
 
 	if val > cached {
-		s.cache.Add(key, val)
+		s.metricCache.Add(key, val)
 		return true, val - cached
 	}
 

receiver/sqlserverreceiver/scraper_test.go

@@ -388,7 +388,7 @@ func TestQueryTextAndPlanQuery(t *testing.T) {
 	assert.NotNil(t, scrapers)
 
 	scraper := scrapers[0]
-	assert.NotNil(t, scraper.cache)
+	assert.NotNil(t, scraper.metricCache)
 
 	const totalElapsedTime = "total_elapsed_time"
 	const rowsReturned = "total_rows"
@@ -447,7 +447,7 @@ func TestInvalidQueryTextAndPlanQuery(t *testing.T) {
 	assert.NotNil(t, scrapers)
 
 	scraper := scrapers[0]
-	assert.NotNil(t, scraper.cache)
+	assert.NotNil(t, scraper.metricCache)
 
 	const totalElapsedTime = "total_elapsed_time"
 	const rowsReturned = "total_rows"
@@ -543,7 +543,7 @@ func TestRecordDatabaseSampleQuery(t *testing.T) {
 			assert.NotNil(t, scrapers)
 
 			scraper := scrapers[0]
-			assert.NotNil(t, scraper.cache)
+			assert.NotNil(t, scraper.metricCache)
 
 			scraper.client = tc.mockClient(scraper.instanceName, scraper.sqlQuery)