Merge pull request #87 from sv-tools/fix-propagate-dump-mode

Fix __propagate_dump_mode__ for list nested

Author: SVilgelm

marshmallow_objects/models.py

@@ -159,7 +159,12 @@ def __propagate_dump_mode__(self, value):
             if isinstance(field, fields.Nested):
                 nested = getattr(self, name, None)
                 if nested is not None and nested != marshmallow.missing:
-                    nested.__propagate_dump_mode__(value)
+                    if isinstance(nested, list):
+                        for sub_nested in nested:
+                            if sub_nested is not None and sub_nested != marshmallow.missing:
+                                sub_nested.__propagate_dump_mode__(value)
+                    else:
+                        nested.__propagate_dump_mode__(value)
 
     @contextlib.contextmanager
     def __dump_mode_on__(self):

tests/test_models.py

@@ -539,15 +539,26 @@ class MissingCompany(marshmallow.Model):
     name = marshmallow.fields.String()
     owner = marshmallow.NestedModel(MissingPerson)
     hr = marshmallow.NestedModel(MissingPerson, allow_none=True)
+    workers = marshmallow.NestedModel(MissingPerson, many=True, allow_none=True)
 
 
 class TestMissingFields(unittest.TestCase):
-    def test_missing_filed(self):
+    def test_field(self):
         self.assertEqual({"name": "John Doe"}, MissingPerson(name="John Doe").dump())
 
-    def test_nested_missing_filed(self):
+    def test_nested_field(self):
         self.assertEqual({"owner": {"name": "John Doe"}}, MissingCompany(owner={"name": "John Doe"}).dump())
 
+    def test_nested_none(self):
+        obj = MissingCompany(owner={"name": "John Doe"})
+        self.assertIsNone(obj.hr)
+        self.assertEqual({"owner": {"name": "John Doe"}}, obj.dump())
+
+    def test_nested_list(self):
+        obj = MissingCompany(owner={"name": "John Doe"}, workers=[{"name": "Bob"}])
+        self.assertEqual(1, len(obj.workers))
+        self.assertEqual({"owner": {"name": "John Doe"}, "workers": [{"name": "Bob"}]}, obj.dump())
+
 
 class SelfNested(marshmallow.Model):
     name = marshmallow.fields.String()