feat: Allow archiving on destroy.

[kad-hollac1]

No description provided.

[kad-hollac1]

Similarly to https://gitea.com/gitea/terraform-provider-gitea/commit/8d483a8a8df956a026defed92f313258197a4858.
I'm not (yet) sure how to test this. How to delete a resource explicitly?

[acch]

Hi @kad-hollac1, thanks for opening this PR! Can you describe the specific scenario you're addressing with this change?

Also, please take a look at the linter errors.

[kad-hollac1]

Sure! In our organisation, we're moving towards managing our Forgejo instance from code, including the repositories. As our developers are human, we want to prevent them from (accidentally) deleting data. As such we want to preserve a repository when it is removed from state by Terraform.

We can set a lifecycle tag to prevent destroy, but that means that that teams keep unused repositories in their configuration. Hence we've taken the GitHub route to implement [0].

[0] https://github.com/integrations/terraform-provider-github/blob/main/github/resource_github_repository.go#L326

[acch]

Hi @kad-hollac1, many thanks for the explanation. This looks like an interesting approach - thank you very much for the contribution!

We should add some testing for the behavior, though. I'd suggest the following approach:

1. Add a test step to create a repo with archive_on_destroy = true.
2. Add a test step without the repo configuration. This will cause terraform apply to destroy/archive the resource, and remove it from state.
3. Add a test step with an import block. This will cause terraform apply to re-import the resource. All attributes should remain unchanged; except for archived, which should now be true.

Does this make sense?

[kad-hollac1]

I've put it in two steps, the second step has only the data source of the repo. Thanks for the suggestion! :)

[EDIT]
The import step is still needed to be able to delete the testing org afterwards, so I still added it.

[acch]

Thanks much @kad-hollac1!

The code looks good, merging it now.

[kad-hollac1]

Thank you! for the review and maintaining this provider. :)