chore: Improving coverage (#16)

* Improving coverage

* More coverage

* reformat

* coverage on exception

* More coverage on branches

* More coverage

* More coverage

* Don't use assert

Author: svaningelgem

src/smartschool/__init__.py

@@ -1,7 +1,7 @@
 from .agenda import SmartschoolHours, SmartschoolLessons, SmartschoolMomentInfos
 from .courses import CourseCondensed, Courses, DocumentOrFolderItem, FileItem, FolderItem, TopNavCourses
 from .credentials import EnvCredentials, PathCredentials
-from .exceptions import SmartSchoolAuthenticationError, SmartSchoolDownloadError, SmartSchoolException
+from .exceptions import SmartSchoolAuthenticationError, SmartSchoolDownloadError, SmartSchoolException, SmartSchoolParsingError
 from .future_tasks import FutureTasks
 from .messages import (
     AdjustMessageLabel,
@@ -47,6 +47,7 @@
     "SmartSchoolAuthenticationError",
     "SmartSchoolDownloadError",
     "SmartSchoolException",
+    "SmartSchoolParsingError",
     "Smartschool",
     "SmartschoolHours",
     "SmartschoolLessons",

src/smartschool/common.py

@@ -150,7 +150,10 @@ def bs4_html(html: str | bytes | Response) -> BeautifulSoup:
 def get_all_values_from_form(html: BeautifulSoup, form_selector: str):
     """Extract form input values from HTML."""
     form = html.select(form_selector)
-    assert len(form) == 1, f"We should have only 1 form. We got {len(form)}!"
+
+    if len(form) != 1:
+        raise AssertionError(f"We should have only 1 form. We got {len(form)}!")
+
     form = form[0]
 
     all_inputs = form.find_all(["input", "button", "textarea", "select"])
@@ -218,7 +221,9 @@ def fill_form(response: Response, form_selector, values: dict[str, str]) -> dict
         else:
             data[name] = input_["value"]
 
-    assert len(values) == 0, f"You didn't use: {sorted(values)}"
+    if len(values) != 0:
+        raise AssertionError(f"You didn't use: {sorted(values)}")
+
     return data
 
 

tests/courses_e2e_tests.py

@@ -3,7 +3,7 @@
 import pytest
 
 from smartschool import Smartschool, TopNavCourses
-from smartschool.courses import CourseCondensed, FolderItem
+from smartschool.courses import CourseCondensed, FolderItem, InternetShortcut
 
 
 @pytest.fixture
@@ -55,8 +55,9 @@ def test_full_workflow(courses: list[CourseCondensed], tmp_path):
     assert pptx_file.filename == "Persoonlijke kunstinteresse.pptx"
 
 
-def test_shortcut_via_window_open_click(courses: list[CourseCondensed], tmp_path):
+def test_shortcut_via_inline_link(courses: list[CourseCondensed], tmp_path):
     shortcut = courses[4].items[1].items[8]  # chemie / oefeningen en verbetersleutels / shortcut
+
     assert shortcut.name == "extra oefeningen elektrolyten en ionisatie+dissociatie"
     assert shortcut.filename == "extra oefeningen elektrolyten en ionisatie_dissociatie.url"
     assert shortcut.mime_type == "html"
@@ -78,3 +79,17 @@ def test_shortcut_via_iframe_src(courses: list[CourseCondensed], tmp_path):
     assert shortcut.size_kb == pytest.approx(1485.0)
     assert shortcut.last_modified == datetime(2020, 6, 19, 11, 20).astimezone()
     assert shortcut.link == "https://www.youtube.com/embed/Zm-g5PpzsEE"
+
+
+def test_shortcut_via_onclick(courses: list[CourseCondensed], tmp_path):
+    shortcut = courses[-1].items[0].items[-1]  # Wiskunde / Binnemans / shortcut
+
+    assert isinstance(shortcut, InternetShortcut)
+    assert shortcut.name == "Puntensysteem portfolio"
+    assert shortcut.parent.name == "4AEC, 4CNW - J. Binnemans"
+    assert shortcut.filename == "Puntensysteem portfolio.url"
+    assert shortcut.id == 464462
+    assert shortcut.mime_type == "html"
+    assert shortcut.size_kb == pytest.approx(415.0)
+    assert shortcut.last_modified == datetime(2024, 10, 9, 20, 43).astimezone()
+    assert shortcut.link == "/Documents/Download/Index/htm/1/courseID/1975/docID/464462/ssID/49"

tests/courses_folder_item_tests.py

@@ -0,0 +1,62 @@
+import pytest
+from requests import RequestException
+
+from smartschool import CourseCondensed, FolderItem, Smartschool, SmartSchoolException, SmartSchoolParsingError
+
+
+@pytest.fixture
+def folder(session: Smartschool) -> FolderItem:
+    return FolderItem(
+        session=session,
+        parent=None,
+        course=CourseCondensed(
+            session=session,
+            name="Course",
+            teacher="Teacher",
+            url="url",
+        ),
+        name="Name",
+    )
+
+
+def test_get_folder_html_exception_handling(folder, mocker):
+    """Test exception is wrapped in SmartSchoolException."""
+    mocker.patch.object(folder.session, "get", side_effect=RequestException("Network error"))
+
+    with pytest.raises(SmartSchoolException, match="Failed to fetch folder HTML: Network error"):
+        folder._get_folder_html()
+
+
+def test_get_mime_from_row_image_return_none(folder, mocker):
+    """Test return None when no background-image found."""
+    mock_row = mocker.Mock()
+    mock_div = mocker.Mock()
+    mock_div.get.return_value = "color: red; font-size: 12px"
+    mock_row.select_one.return_value = mock_div
+
+    result = folder._get_mime_from_row_image(mock_row)
+
+    assert result is None
+
+
+def test_get_mime_from_row_image_continue_branch(folder, mocker):
+    """Test continue branch when entry is empty."""
+    mock_row = mocker.Mock()
+    mock_div = mocker.Mock()
+    mock_div.get.return_value = "  ; ; background-image: url(/mime_type_pdf/icon.png)"
+    mock_row.select_one.return_value = mock_div
+
+    result = folder._get_mime_from_row_image(mock_row)
+
+    assert result == "pdf"
+
+
+def test_parse_folder_row_exception(folder, mocker):
+    """Test exception when no smsc_cm_link found."""
+    mock_row = mocker.Mock()
+    mock_link = mocker.Mock()
+    mock_link.get.return_value = ["other_class", "different_class"]  # no smsc_cm_link
+    mock_row.select.return_value = [mock_link]
+
+    with pytest.raises(SmartSchoolParsingError, match="No browse URL found"):
+        folder._parse_folder_row(mock_row)

tests/planner_tests.py

@@ -1,7 +1,8 @@
+import pytest
 import time_machine
 
 from smartschool import Smartschool
-from smartschool.planner import PlannedElements
+from smartschool.planner import ApplicableAssignmentTypes, PlannedElements
 
 
 @time_machine.travel("2025-05-06")
@@ -13,3 +14,17 @@ def test_periods_happy_flow(session: Smartschool):
     assert sut[0].courses[0].name == "Godsdienst"
     assert sut[0].plannedElementType == "planned-placeholders"
     assert not sut[0].unconfirmed
+
+
+def test_applicable_assignment_types(session: Smartschool):
+    sut = list(ApplicableAssignmentTypes(session))
+
+    assert len(sut) == 7
+
+    obj = sut[0]
+    assert obj.abbreviation == "-"
+    assert obj.id == "12657aa0-3b29-4977-925b-e2a0f133f2ba"
+    assert obj.isVisible is True
+    assert obj.name == "-"
+    assert obj.platformId == 49
+    assert obj.weight == pytest.approx(1.0)