Skip to content

fix: Round values when determining if a pane is collapsed #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntabyte merged 2 commits into from
Jul 30, 2025
Merged

fix: Round values when determining if a pane is collapsed #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b991c
fix: Round values when determining if a pane is collapsed
reinhard-sanz Jul 28, 2025
dde2b95
hide: add changeset
reinhard-sanz Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/slimy-pillows-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"paneforge": patch
---

fix: issue where isPaneCollapsed wrongfully returned false due to rounding issues
2 changes: 1 addition & 1 deletion packages/paneforge/src/lib/paneforge.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ export class PaneGroupState {
paneSize,
} = paneDataHelper(paneDataArray, pane, layout);

return collapsible === true && paneSize === collapsedSize;
return collapsible === true && areNumbersAlmostEqual(paneSize, collapsedSize);
};

expandPane = (pane: PaneState) => {
Expand Down
Loading