Added tests, fmt, updated docs

Author: sveinbjornt

README.md

@@ -275,6 +275,7 @@ pip install .
 
 ## Version History
 
+* 0.5.8: Updated address and placename data. Added municipality name data to address records. Now requires Python 3.9+ (27/02/2025)
 * 0.5.7: Updated address and placename data. Now requires Python 3.8+ (20/09/2024)
 * 0.5.6: Updated address and placename data (11/08/2023)
 * 0.5.5: Updated address and placename data. Removed ISN93 coords. Now requires Python 3.7+ (11/12/2022)

build_postcodes.py

@@ -1,27 +1,26 @@
 #!/usr/bin/env python3
 """
 
-    Fetch list of postcodes from the Icelandic postal service,
-    create and print dict mapping postcode to placename and
-    other related information. Also adds placenames in the
-    nominative case (nefnifall) since the source data only
-    includes placenames in dative (þágufall).
+Fetch list of postcodes from the Icelandic postal service,
+create and print dict mapping postcode to placename and
+other related information. Also adds placenames in the
+nominative case (nefnifall) since the source data only
+includes placenames in dative (þágufall).
 
-    https://www.postur.is/gogn/Gotuskra/postnumer.txt
+https://www.postur.is/gogn/Gotuskra/postnumer.txt
 
 """
 
-import requests
-import pprint
-import logging
 import csv
+import logging
+import pprint
 from io import StringIO
 
+import requests
 from reynir import NounPhrase
 
 from iceaddr.postcodes import POSTCODES
 
-
 POSTCODES_REMOTE_URL = "https://www.postur.is/gogn/Gotuskra/postnumer.txt"
 
 
@@ -34,7 +33,7 @@ def main() -> None:
     pc_keys = pc.keys()
     pp = pprint.PrettyPrinter(indent=4)
 
-    req = requests.get(POSTCODES_REMOTE_URL, allow_redirects=True)
+    req = requests.get(POSTCODES_REMOTE_URL, allow_redirects=True, timeout=10)
     f = StringIO(req.text)
 
     changed = False

tests/test_iceaddr.py

@@ -21,6 +21,8 @@
     POSTCODES,
     iceaddr_lookup,
     iceaddr_suggest,
+    municipality_code_for_municipality,
+    municipality_for_municipality_code,
     nearest_addr,
     nearest_placenames,
     postcode_lookup,
@@ -97,6 +99,9 @@ def test_address_suggestions():
     assert res[0]["heiti_nf"] == "Öldugata"
     assert res[0]["husnr"] == 4
     assert res[0]["stadur_nf"] == "Reykjavík"
+    assert res[0]["postnr"] == 101
+    assert res[0]["svaedi_nf"] == "Höfuðborgarsvæðið"
+    assert res[0]["svfheiti"] == "Reykjavíkurborg"
 
     res = iceaddr_suggest("Öldugata 4, Rey")
     assert [n["stadur_tgf"] for n in res] == ["Reykjavík", "Reyðarfirði"]
@@ -161,6 +166,13 @@ def test_postcode_lookup():
     assert postcodes_for_region("Höfuðborgarsvæðið")
 
 
+def test_municipality_lookup():
+    """Test municipality code lookup functions."""
+    assert municipality_code_for_municipality("Reykjavíkurborg") == 0
+
+    assert municipality_for_municipality_code(0) == "Reykjavíkurborg"
+
+
 FISKISLOD_31_COORDS = (64.1560233, -21.951407)
 OLDUGATA_4_COORDS = (64.148446, -21.944933)
 POSTCODE_101 = 101