fix: dynamically suggest package manager installation command in migrate scripts (#495)

* added pm-detector to migrate package, used for dynamic suggestions in cli

* format, lint

* Use resolveCommand for futureproofing (reverted accidental merge)

* Create moody-mirrors-wait.md

---------

Co-authored-by: Manuel Serret <[email protected]>
Co-authored-by: Manuel <[email protected]>

Author: garikAsplund

.changeset/moody-mirrors-wait.md

@@ -0,0 +1,5 @@
+---
+"svelte-migrate": patch
+---
+
+fix: dynamically suggest package manager installation command in `migrate` scripts

packages/migrate/migrations/app-state/index.js

@@ -6,6 +6,7 @@ import semver from 'semver';
 import glob from 'tiny-glob/sync.js';
 import { bail, check_git, migration_succeeded, update_svelte_file } from '../../utils.js';
 import { transform_svelte_code, update_pkg_json } from './migrate.js';
+import { detect, resolveCommand } from 'package-manager-detector';
 
 export async function migrate() {
 	if (!fs.existsSync('package.json')) {
@@ -94,8 +95,15 @@ export async function migrate() {
 	/** @type {(s: string) => string} */
 	const cyan = (s) => pc.bold(pc.cyan(s));
 
-	// TODO: use package-manager-detector here
-	const tasks = ["install the updated dependencies ('npm i' / 'pnpm i' / etc)"];
+	const detected = await detect({ cwd: process.cwd() });
+	const pm = detected?.name ?? 'npm';
+	const cmd = /** @type {import('package-manager-detector').ResolvedCommand} */ (
+		resolveCommand(pm, 'install', [])
+	);
+
+	const tasks = [
+		`Install the updated dependencies by running ${cyan(`${cmd.command} ${cmd.args.join(' ')}`)}`
+	];
 	if (use_git) {
 		tasks.push(cyan('git commit -m "migration to $app/state"'));
 		tasks.push(`Run ${cyan('git diff')} to review changes.`);

packages/migrate/migrations/svelte-5/index.js

@@ -19,6 +19,7 @@ import { migrate as migrate_svelte_4 } from '../svelte-4/index.js';
 import { migrate as migrate_sveltekit_2 } from '../sveltekit-2/index.js';
 import { transform_svelte_code as transform_app_state_code } from '../app-state/migrate.js';
 import { transform_module_code, transform_svelte_code, update_pkg_json } from './migrate.js';
+import { detect, resolveCommand } from 'package-manager-detector';
 
 export async function migrate() {
 	if (!fs.existsSync('package.json')) {
@@ -217,8 +218,13 @@ export async function migrate() {
 	/** @type {(s: string) => string} */
 	const cyan = (s) => pc.bold(pc.cyan(s));
 
+	const detected = await detect({ cwd: process.cwd() });
+	const pm = detected?.name ?? 'npm';
+	const cmd = /** @type {import('package-manager-detector').ResolvedCommand} */ (
+		resolveCommand(pm, 'install', [])
+	);
 	const tasks = [
-		"install the updated dependencies ('npm i' / 'pnpm i' / etc) " +
+		`Install the updated dependencies by running ${cyan(`${cmd.command} ${cmd.args.join(' ')}`)} ` +
 			'(note that there may be peer dependency issues when not all your libraries officially support Svelte 5 yet. In this case try installing with the --force option)',
 		use_git && cyan('git commit -m "migration to Svelte 5"'),
 		'Review the migration guide at https://svelte.dev/docs/svelte/v5-migration-guide',

packages/migrate/migrations/sveltekit-2/index.js

@@ -19,6 +19,7 @@ import {
 	update_svelte_config,
 	update_tsconfig_content
 } from './migrate.js';
+import { detect, resolveCommand } from 'package-manager-detector';
 
 export async function migrate() {
 	if (!fs.existsSync('package.json')) {
@@ -137,8 +138,14 @@ export async function migrate() {
 	/** @type {(s: string) => string} */
 	const cyan = (s) => pc.bold(pc.cyan(s));
 
+	const detected = await detect({ cwd: process.cwd() });
+	const pm = detected?.name ?? 'npm';
+	const cmd = /** @type {import('package-manager-detector').ResolvedCommand} */ (
+		resolveCommand(pm, 'install', [])
+	);
+
 	const tasks = [
-		'Run npm install (or the corresponding installation command of your package manager)',
+		`Install the updated dependencies by running ${cyan(`${cmd.command} ${cmd.args.join(' ')}`)}`,
 		use_git && cyan('git commit -m "migration to SvelteKit 2"'),
 		'Review the migration guide at https://svelte.dev/docs/kit/migrating-to-sveltekit-2',
 		'Read the updated docs at https://svelte.dev/docs/kit',

packages/migrate/package.json

@@ -30,6 +30,7 @@
 		"@clack/prompts": "^0.9.0",
 		"import-meta-resolve": "^4.1.0",
 		"magic-string": "^0.30.15",
+		"package-manager-detector": "^0.2.7",
 		"picocolors": "^1.1.1",
 		"semver": "^7.6.3",
 		"tiny-glob": "^0.2.9",