rmv ps-tree

Author: jycouet

packages/cli/lib/testing.ts

@@ -4,7 +4,6 @@ import process from 'node:process';
 import degit from 'degit';
 import { exec } from 'tinyexec';
 import { create } from '@sveltejs/create';
-import pstree, { type PS } from 'ps-tree';
 
 export { addPnpmBuildDependencies } from '../utils/package-manager.ts';
 export type ProjectVariant = 'kit-js' | 'kit-ts' | 'vite-js' | 'vite-ts';
@@ -122,31 +121,18 @@ export async function startPreview({
 	});
 }
 
-async function getProcessTree(pid: number) {
-	return new Promise<readonly PS[]>((res, rej) => {
-		pstree(pid, (err, children) => {
-			if (err) rej(err);
-			res(children);
-		});
-	});
-}
-
 async function terminate(pid: number) {
-	const children = await getProcessTree(pid);
-	// the process tree is ordered from parents -> children,
-	// so we'll iterate in the reverse order to terminate the children first
-	for (let i = children.length - 1; i >= 0; i--) {
-		const child = children[i];
-		const pid = Number(child.PID);
-		kill(pid);
-	}
-	kill(pid);
-}
-
-function kill(pid: number) {
 	try {
-		process.kill(pid);
+		if (process.platform === 'win32') {
+			await exec(`taskkill /pid ${pid} /T /F`); // on windows, use taskkill to terminate the process tree
+		} else {
+			process.kill(-pid, 'SIGTERM'); // Kill the process group
+		}
 	} catch {
-		// this can happen if a process has been automatically terminated.
+		try {
+			process.kill(pid, 'SIGTERM'); // Kill just the process
+		} catch {
+			// Process might already be terminated
+		}
 	}
 }

packages/cli/package.json

@@ -35,13 +35,11 @@
 		"@sveltejs/cli-core": "workspace:*",
 		"@sveltejs/create": "workspace:*",
 		"@types/degit": "^2.8.6",
-		"@types/ps-tree": "^1.1.6",
 		"commander": "^13.1.0",
 		"degit": "^2.8.4",
 		"empathic": "^1.1.0",
 		"package-manager-detector": "^0.2.11",
 		"picocolors": "^1.1.1",
-		"ps-tree": "^1.2.0",
 		"tinyexec": "^0.3.2",
 		"valibot": "^0.41.0"
 	},