fix stringify not picking up negative zero if a normal zero has appeared before it #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 82f6620 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this while I was messing around with this package after I started doing some sveltekit prototyping. Just run the test I added in this PR without the included fix and notice how it stringifies it to just a normal zero.
I think the reason this fails is because
indexes.has(thing)will return true ifthingis negative zero andindexescontains a value for normal zero.So my proposed fix is fairly simple: just first check for all the constants before checking the indexes map. Now I do not know if this has any unintended side-effects. So if I overlooked something feel free to deny this PR and cook up something else 😛.
Now while I dont really need correct support for negative zero myself, since the readme explicitly mentions support for it, I figured might as well PR it 😄.