|
| 1 | +import type { AST } from "svelte-eslint-parser" |
| 2 | +import type * as ESTree from "estree" |
| 3 | +import { createRule } from "../utils" |
| 4 | +import { findVariable } from "../utils/ast-utils" |
| 5 | + |
| 6 | +const PHRASES = { |
| 7 | + ObjectExpression: "object", |
| 8 | + ArrayExpression: "array", |
| 9 | + ClassExpression: "class", |
| 10 | + Literal(node: ESTree.Literal): string | null { |
| 11 | + if ("regex" in node) { |
| 12 | + return "regex value" |
| 13 | + } |
| 14 | + if ("bigint" in node) { |
| 15 | + return "bigint value" |
| 16 | + } |
| 17 | + if (node.value == null) { |
| 18 | + return null |
| 19 | + } |
| 20 | + return `${typeof node.value} value` |
| 21 | + }, |
| 22 | + TemplateLiteral: "string value", |
| 23 | +} |
| 24 | +export default createRule("no-not-function-handler", { |
| 25 | + meta: { |
| 26 | + docs: { |
| 27 | + description: "disallow use of not function in event handler", |
| 28 | + category: "Possible Errors", |
| 29 | + recommended: true, |
| 30 | + }, |
| 31 | + schema: [], |
| 32 | + messages: { |
| 33 | + unexpected: "Unexpected {{phrase}} in event handler.", |
| 34 | + }, |
| 35 | + type: "problem", // "problem", or "layout", |
| 36 | + }, |
| 37 | + create(context) { |
| 38 | + /** Find data expression */ |
| 39 | + function findRootExpression( |
| 40 | + node: ESTree.Expression, |
| 41 | + already = new Set<ESTree.Identifier>(), |
| 42 | + ): ESTree.Expression { |
| 43 | + if (node.type !== "Identifier" || already.has(node)) { |
| 44 | + return node |
| 45 | + } |
| 46 | + already.add(node) |
| 47 | + const variable = findVariable(context, node) |
| 48 | + if (!variable || variable.defs.length !== 1) { |
| 49 | + return node |
| 50 | + } |
| 51 | + const def = variable.defs[0] |
| 52 | + if (def.type === "Variable") { |
| 53 | + if (def.parent.kind === "const" && def.node.init) { |
| 54 | + const init = def.node.init |
| 55 | + return findRootExpression(init, already) |
| 56 | + } |
| 57 | + } |
| 58 | + return node |
| 59 | + } |
| 60 | + |
| 61 | + /** Verify for `on:` directive value */ |
| 62 | + function verify(node: AST.SvelteEventHandlerDirective["expression"]) { |
| 63 | + if (!node) { |
| 64 | + return |
| 65 | + } |
| 66 | + const expression = findRootExpression(node) |
| 67 | + |
| 68 | + if ( |
| 69 | + expression.type !== "ObjectExpression" && |
| 70 | + expression.type !== "ArrayExpression" && |
| 71 | + expression.type !== "ClassExpression" && |
| 72 | + expression.type !== "Literal" && |
| 73 | + expression.type !== "TemplateLiteral" |
| 74 | + ) { |
| 75 | + return |
| 76 | + } |
| 77 | + const phraseValue = PHRASES[expression.type] |
| 78 | + const phrase = |
| 79 | + typeof phraseValue === "function" |
| 80 | + ? phraseValue(expression as never) |
| 81 | + : phraseValue |
| 82 | + if (phrase == null) { |
| 83 | + return |
| 84 | + } |
| 85 | + context.report({ |
| 86 | + node, |
| 87 | + messageId: "unexpected", |
| 88 | + data: { |
| 89 | + phrase, |
| 90 | + }, |
| 91 | + }) |
| 92 | + } |
| 93 | + |
| 94 | + return { |
| 95 | + SvelteDirective(node) { |
| 96 | + if (node.kind !== "EventHandler") { |
| 97 | + return |
| 98 | + } |
| 99 | + verify(node.expression) |
| 100 | + }, |
| 101 | + } |
| 102 | + }, |
| 103 | +}) |
0 commit comments