Skip to content

Commit 60e784e

Browse files
authored
chore: fix tests to follow latest Svelte 5 (#751)
I just added Node 22 but CI does not pass in #750 sveltejs/svelte#11327 changes warning messages, so I mainly copied exist tests and optimized for Svelte 5.
1 parent ade400a commit 60e784e

File tree

137 files changed

+739
-105
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

137 files changed

+739
-105
lines changed

docs-svelte-kit/src/lib/components/ESLintPlayground.svelte

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,9 @@
190190
<ol>
191191
{#each messages as msg, i (`${msg.line}:${msg.column}:${msg.ruleId}@${i}`)}
192192
<li class="message">
193-
<!-- svelte-ignore a11y-invalid-attribute -->
194-
<a href="#" on:click={(evt) => onClickMessage(evt, msg)} class="message-link"
195-
>[{msg.line}:{msg.column}]</a
196-
>:
193+
<button on:click={(evt) => onClickMessage(evt, msg)} class="message-link">
194+
[{msg.line}:{msg.column}]
195+
</button>:
197196
{msg.message}
198197
<a
199198
class="rule-link {getRule(msg.ruleId)?.classes}"
@@ -268,6 +267,12 @@
268267
color: #8080f2;
269268
}
270269
.message-link {
270+
background-color: transparent;
271+
border: none;
272+
cursor: pointer;
273+
outline: none;
274+
padding: 0;
275+
appearance: none;
271276
color: #40b3ff;
272277
}
273278
</style>

docs-svelte-kit/src/routes/+layout.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
<SideMenu {sidebarOpen} hiddenMenu={frontmatter.hiddenMenu} />
3535

36-
<!-- svelte-ignore a11y-no-noninteractive-element-interactions -->
36+
<!-- svelte-ignore a11y_no_noninteractive_element_interactions -->
3737
<main
3838
class:hidden-menu={frontmatter.hiddenMenu}
3939
on:click={sidebarOpen ? resetSidebarOpen : null}

eslint.config.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ const config = [
128128
},
129129
rules: {
130130
'n/file-extension-in-import': 'off',
131-
'n/no-unsupported-features/es-syntax': 'off'
131+
'n/no-unsupported-features/es-syntax': 'off',
132+
'n/no-unsupported-features/es-builtins': 'off'
132133
}
133134
},
134135
{
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
<!-- svelte-ignore a11y-autofocus a11y-missing-attribute -->
1+
<!-- svelte-ignore a11y_autofocus a11y_missing_attribute -->
22
<img src="foo" alt="Foo" />
33

4-
<!-- svelte-ignore a11y-autofocus a11y-missing-attribute -->
4+
<!-- svelte-ignore a11y_autofocus a11y_missing_attribute -->
55
<img src="foo" alt="Foo" autofocus />
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"svelte": ">=5.0.0-0"
3+
}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
- message: svelte-ignore comment is used, but not warned
2+
line: 1
3+
column: 20
4+
suggestions: null
5+
- message: svelte-ignore comment is used, but not warned
6+
line: 1
7+
column: 35
8+
suggestions: null
9+
- message: svelte-ignore comment is used, but not warned
10+
line: 4
11+
column: 35
12+
suggestions: null
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<!-- svelte-ignore a11y-autofocus a11y-missing-attribute -->
2+
<img src="foo" alt="Foo" />
3+
4+
<!-- svelte-ignore a11y-autofocus a11y-missing-attribute -->
5+
<img src="foo" alt="Foo" autofocus />
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"svelte": "^3.0.0 || ^4.0.0"
3+
}

tests/fixtures/rules/no-unused-svelte-ignore/invalid/invalid-svelte-ignore01-input.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div>
22
{#if true}
33
A
4-
<!-- svelte-ignore a11y-label-has-associated-control a11y-no-noninteractive-tabindex -->
4+
<!-- svelte-ignore a11y_label_has_associated_control a11y_no_noninteractive_tabindex -->
55
{:else}
66
<label tabindex="0">Click</label>
77
<ul tabindex="0"></ul>
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"svelte": ">=5.0.0-0"
3+
}

0 commit comments

Comments
 (0)