fix: rename variable references within the current scope

Author: 43081j

packages/eslint-plugin-svelte/src/rules/derived-has-same-inputs-outputs.ts

@@ -2,6 +2,7 @@ import type { TSESTree } from '@typescript-eslint/types';
 import { createRule } from '../utils/index.js';
 import type { RuleContext } from '../types.js';
 import { extractStoreReferences } from './reference-helpers/svelte-store.js';
+import { getSourceCode } from '../utils/compat.js';
 
 export default createRule('derived-has-same-inputs-outputs', {
 	meta: {
@@ -55,7 +56,19 @@ export default createRule('derived-has-same-inputs-outputs', {
 					loc: fnParam.loc,
 					messageId: 'unexpected',
 					data: { name: expectedName },
-					fix: (fixer) => fixer.replaceText(fnParam, expectedName)
+					fix: (fixer) => {
+						const scope = getSourceCode(context).getScope(fn.body);
+						const variable = scope.variables.find((variable) => variable.name === fnParam.name);
+
+						if (!variable) {
+							return fixer.replaceText(fnParam, expectedName);
+						}
+
+						return [
+							fixer.replaceText(fnParam, expectedName),
+							...variable.references.map((ref) => fixer.replaceText(ref.identifier, expectedName))
+						];
+					}
 				});
 			}
 		}
@@ -84,7 +97,21 @@ export default createRule('derived-has-same-inputs-outputs', {
 							loc: element.loc,
 							messageId: 'unexpected',
 							data: { name: expectedName },
-							fix: (fixer) => fixer.replaceText(element, expectedName)
+							fix: (fixer) => {
+								const scope = getSourceCode(context).getScope(fn.body);
+								const variable = scope.variables.find((variable) => variable.name === element.name);
+
+								if (!variable) {
+									return fixer.replaceText(element, expectedName);
+								}
+
+								return [
+									fixer.replaceText(element, expectedName),
+									...variable.references.map((ref) =>
+										fixer.replaceText(ref.identifier, expectedName)
+									)
+								];
+							}
 						});
 					}
 				}

packages/eslint-plugin-svelte/src/types.ts

@@ -366,4 +366,6 @@ export interface SourceCode {
 	getCommentsAfter(nodeOrToken: NodeOrToken | AST.Token): AST.Comment[];
 
 	getCommentsInside(node: NodeOrToken): AST.Comment[];
+
+	getScope(node: NodeOrToken): Scope;
 }

packages/eslint-plugin-svelte/tests/fixtures/rules/derived-has-same-inputs-outputs/invalid/test01-errors.yaml

@@ -30,3 +30,27 @@
   line: 18
   column: 22
   suggestions: null
+- message: The argument name should be '$a'.
+  line: 21
+  column: 13
+  suggestions: null
+- message: The argument name should be '$a'.
+  line: 28
+  column: 13
+  suggestions: null
+- message: The argument name should be '$e'.
+  line: 37
+  column: 19
+  suggestions: null
+- message: The argument name should be '$f'.
+  line: 37
+  column: 22
+  suggestions: null
+- message: The argument name should be '$e'.
+  line: 46
+  column: 19
+  suggestions: null
+- message: The argument name should be '$f'.
+  line: 46
+  column: 22
+  suggestions: null

packages/eslint-plugin-svelte/tests/fixtures/rules/derived-has-same-inputs-outputs/invalid/test01-input.js

@@ -18,3 +18,39 @@ derived([null, l], ([$m, $n]) => {
 derived([o, null], ([$p, $q]) => {
 	/** do nothing */
 });
+derived(a, (b) => {
+	doSomethingWith(b);
+
+	somethingWithACallback(() => {
+		b;
+	});
+});
+derived(a, (b) => {
+	b;
+
+	somethingWithACallback(() => {
+		// purposely shadow the var, this should not be updated
+		const b = 303;
+		b;
+	});
+});
+derived([e, f], ([g, h]) => {
+	g;
+	h;
+
+	somethingWithACallback(() => {
+		g;
+		h;
+	});
+});
+derived([e, f], ([g, h]) => {
+	g;
+	h;
+
+	somethingWithACallback(() => {
+		const g = 303;
+		const h = 808;
+		g;
+		h;
+	});
+});

packages/eslint-plugin-svelte/tests/fixtures/rules/derived-has-same-inputs-outputs/invalid/test01-output.js

@@ -18,3 +18,39 @@ derived([null, l], ([$m, $l]) => {
 derived([o, null], ([$o, $q]) => {
 	/** do nothing */
 });
+derived(a, ($a) => {
+	doSomethingWith($a);
+
+	somethingWithACallback(() => {
+		$a;
+	});
+});
+derived(a, ($a) => {
+	$a;
+
+	somethingWithACallback(() => {
+		// purposely shadow the var, this should not be updated
+		const b = 303;
+		b;
+	});
+});
+derived([e, f], ([$e, h]) => {
+	$e;
+	h;
+
+	somethingWithACallback(() => {
+		$e;
+		h;
+	});
+});
+derived([e, f], ([$e, h]) => {
+	$e;
+	h;
+
+	somethingWithACallback(() => {
+		const g = 303;
+		const h = 808;
+		g;
+		h;
+	});
+});