Deprecate rules `no-export-load-in-svelte-module-in-kit-pages` and `valid-prop-names-in-kit-pages`

[marekdedic]

I was looking at these rules and wanted to move them to the "SvelteKit" section, but then I realized that maybe a better thing to do would be to deprecate them? It's a fix for a change that happened in August 2022, so it's probably no longer relevant...

What do you think?

[ota-meshi]

Hmm... Those rules aren't useful for normal use, but they can be useful for users doing migrations.
How about having a new section like Migration?

[marekdedic]

The migrations are from version 2 years old... I think people doing such migrations won't be on v3 of this plugin :D I think it'd be safe to deprecate them in v3 and remove in v4.

Otherwise, creating a new category seems a good alternative. Or we can just move them under SvelteKit

[baseballyama]

If we merge #980, we can automatically apply the rule if a user uses older SvelteKit.

[baseballyama]

Currently, these rules are only executed for +page.svelte, +error.svelte, and +layout.svelte, so I don’t think their execution poses any real performance disadvantages. (In other words, no-export-load-in-svelte-module-in-kit-pages will likely remain a rule that most users never encounter, but it also has no downsides.)

Additionally, I believe valid-prop-names-in-kit-pages remains a useful rule for SvelteKit beginners working with props.