From baa64fed61262d8c7376c20b4ada0a782b0549a8 Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 19 Jan 2025 11:54:53 +0900 Subject: [PATCH 1/2] chore: do not run `prefer-destructured-store-props` rule on Svelte 5 with runes --- .changeset/cyan-experts-arrive.md | 5 +++++ .../src/rules/prefer-destructured-store-props.ts | 11 ++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .changeset/cyan-experts-arrive.md diff --git a/.changeset/cyan-experts-arrive.md b/.changeset/cyan-experts-arrive.md new file mode 100644 index 000000000..04a788d4b --- /dev/null +++ b/.changeset/cyan-experts-arrive.md @@ -0,0 +1,5 @@ +--- +'eslint-plugin-svelte': patch +--- + +chore: do not run `prefer-destructured-store-props` rule on Svelte 5 with runes diff --git a/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts b/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts index 241e64ec6..b11adfec9 100644 --- a/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts +++ b/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts @@ -26,7 +26,16 @@ export default createRule('prefer-destructured-store-props', { fixUseDestructuring: `Using destructuring like $: ({ {{property}} } = {{store}}); will run faster`, fixUseVariable: `Using the predefined reactive variable {{variable}}` }, - type: 'suggestion' + type: 'suggestion', + conditions: [ + { + svelteVersions: ['3/4'] + }, + { + svelteVersions: ['5'], + runes: [false, 'undetermined'] + } + ] }, create(context) { let mainScript: AST.SvelteScriptElement | null = null; From 2b694106bd56ad395a65fa1cd35ce03e9471069b Mon Sep 17 00:00:00 2001 From: baseballyama Date: Sun, 26 Jan 2025 10:40:08 +0900 Subject: [PATCH 2/2] update docs --- .changeset/cyan-experts-arrive.md | 5 ----- docs/rules/prefer-destructured-store-props.md | 3 +++ .../src/rules/prefer-destructured-store-props.ts | 11 +---------- 3 files changed, 4 insertions(+), 15 deletions(-) delete mode 100644 .changeset/cyan-experts-arrive.md diff --git a/.changeset/cyan-experts-arrive.md b/.changeset/cyan-experts-arrive.md deleted file mode 100644 index 04a788d4b..000000000 --- a/.changeset/cyan-experts-arrive.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'eslint-plugin-svelte': patch ---- - -chore: do not run `prefer-destructured-store-props` rule on Svelte 5 with runes diff --git a/docs/rules/prefer-destructured-store-props.md b/docs/rules/prefer-destructured-store-props.md index 66ac5a1d9..ce9890b3f 100644 --- a/docs/rules/prefer-destructured-store-props.md +++ b/docs/rules/prefer-destructured-store-props.md @@ -24,7 +24,10 @@ An example of the improvements can be see in this [REPL](https://svelte.dev/repl diff --git a/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts b/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts index b11adfec9..241e64ec6 100644 --- a/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts +++ b/packages/eslint-plugin-svelte/src/rules/prefer-destructured-store-props.ts @@ -26,16 +26,7 @@ export default createRule('prefer-destructured-store-props', { fixUseDestructuring: `Using destructuring like $: ({ {{property}} } = {{store}}); will run faster`, fixUseVariable: `Using the predefined reactive variable {{variable}}` }, - type: 'suggestion', - conditions: [ - { - svelteVersions: ['3/4'] - }, - { - svelteVersions: ['5'], - runes: [false, 'undetermined'] - } - ] + type: 'suggestion' }, create(context) { let mainScript: AST.SvelteScriptElement | null = null;