-
-
Notifications
You must be signed in to change notification settings - Fork 58
feat: added the no-useless-children-snippet rule #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added the no-useless-children-snippet rule #922
Conversation
🦋 Changeset detectedLatest commit: 4a0df5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
513b696 to
71d34e7
Compare
|
Blocked by #923 which causes the CI errors |
71d34e7 to
f2eaca6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR! The implementation looks good, but I think we need to fix CI errors.
Could you please put a _requirements.json with {"svelte": ">=5.0.0"} in test fixtures directories to exclude old Svelte tests?
Could you also fix the linting errors?
95f0ab5 to
7722590
Compare
|
This PR is looks good, but I made this package ESM. Could you please merge the main branch and fix it by adding |
742f7c6 to
cbf6225
Compare
|
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In cases like this code, “Found an unnecessary children snippet.” appears, but this is incorrect. It would be better to only inspect inside Svelte components.
{#snippet children()}
Hi!
{/snippet}
{@render children()}cbf6225 to
ce84da4
Compare
commit: |
ce84da4 to
4a0df5a
Compare
|
@baseballyama Good catch, fixed & added it as a test :) |
Closes #909