fix: fall back to non-relative resolution when calling resolve(...) outside an event context (#14532)

* fix: fall back to non-relative resolution when calling `resolve(...)` outside an event context

* lint

Author: Rich-Harris

.changeset/common-llamas-argue.md

@@ -0,0 +1,5 @@
+---
+'@sveltejs/kit': patch
+---
+
+fix: fall back to non-relative resolution when calling `resolve(...)` outside an event context

packages/kit/src/runtime/app/paths/server.js

@@ -1,6 +1,6 @@
 import { base, assets, relative } from './internal/server.js';
 import { resolve_route } from '../../../utils/routing.js';
-import { get_request_store } from '@sveltejs/kit/internal/server';
+import { try_get_request_store } from '@sveltejs/kit/internal/server';
 
 /** @type {import('./client.js').asset} */
 export function asset(file) {
@@ -13,19 +13,17 @@ export function resolve(id, params) {
 	const resolved = resolve_route(id, /** @type {Record<string, string>} */ (params));
 
 	if (relative) {
-		const { event, state } = get_request_store();
+		const store = try_get_request_store();
 
-		if (state.prerendering?.fallback) {
-			return resolved;
-		}
-
-		const segments = event.url.pathname.slice(base.length).split('/').slice(2);
-		const prefix = segments.map(() => '..').join('/') || '.';
+		if (store && !store.state.prerendering?.fallback) {
+			const segments = store.event.url.pathname.slice(base.length).split('/').slice(2);
+			const prefix = segments.map(() => '..').join('/') || '.';
 
-		return prefix + resolved;
+			return prefix + resolved;
+		}
 	}
 
-	return resolved;
+	return base + resolved;
 }
 
 export { base, assets, resolve as resolveRoute };

packages/kit/test/apps/basics/src/hooks.server.js

@@ -5,6 +5,7 @@ import fs from 'node:fs';
 import { COOKIE_NAME } from './routes/cookies/shared';
 import { _set_from_init } from './routes/init-hooks/+page.server';
 import { getRequestEvent } from '$app/server';
+import { resolve } from '$app/paths';
 
 // @ts-ignore this doesn't exist in old Node
 Promise.withResolvers ??= () => {
@@ -16,6 +17,9 @@ Promise.withResolvers ??= () => {
 	return d;
 };
 
+// check that this doesn't throw when called outside an event context
+resolve('/');
+
 /**
  * Transform an error into a POJO, by copying its `name`, `message`
  * and (in dev) `stack`, plus any custom properties, plus recursively