You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found this code when I was investigating this issue.
I assume this code should never be run? Ideally an adapter would provide a fallback functionality, right?
If not I find the behavior strange to fallback to an undocumented page, which will result either
into an error, leaving the user clueless how to resolve the issue
render a page with unexpected content
when e.g. a route /[category] exists, it could render a page that won't be displayed correctly because [fallback] is probably not a valid category
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Can someone explain me this line of code?
kit/packages/kit/src/core/postbuild/fallback.js
Line 38 in 2f2ef5f
I found this code when I was investigating this issue.
I assume this code should never be run? Ideally an adapter would provide a fallback functionality, right?
If not I find the behavior strange to fallback to an undocumented page, which will result either
when e.g. a route
/[category]
exists, it could render a page that won't be displayed correctly because[fallback]
is probably not a valid categoryBeta Was this translation helpful? Give feedback.
All reactions