-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: File Upload Progress #14878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: File Upload Progress #14878
Conversation
🦋 Changeset detectedLatest commit: b03a465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Ben McCann <[email protected]>
| }, | ||
| () => issues | ||
| () => issues, | ||
| (path) => deep_get(upload_progress, path) ?? { uploaded: 0, total: 0 } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe set total: 1 here to protect people from dividing by zero?
|
paging @Rich-Harris to see if this can go out with #14775 :-) |
see #14773
Builds on #14775 to use XHRs for file upload progress in forms:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits