Skip to content

Commit 289ac9c

Browse files
authored
(fix) import completion in upper case directory (#915)
Fix case sensitivity config #881
1 parent 28c7a4c commit 289ac9c

File tree

4 files changed

+19
-2
lines changed

4 files changed

+19
-2
lines changed

packages/language-server/src/plugins/typescript/service.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,7 @@ export function createLanguageService(
107107
resolveModuleNames: svelteModuleLoader.resolveModuleNames,
108108
readDirectory: svelteModuleLoader.readDirectory,
109109
getDirectories: ts.sys.getDirectories,
110-
// vscode's uri is all lowercase
111-
useCaseSensitiveFileNames: () => false,
110+
useCaseSensitiveFileNames: () => ts.sys.useCaseSensitiveFileNames,
112111
getScriptKind: (fileName: string) => getSnapshot(fileName).scriptKind
113112
};
114113
let languageService = ts.createLanguageService(host);

packages/language-server/test/plugins/typescript/features/CompletionProvider.test.ts

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,21 @@ describe('CompletionProviderImpl', () => {
340340
}
341341
});
342342

343+
it('provides import completions in file with uppercase directory', async () => {
344+
const { completionProvider, document } = setup('UpperCase/dirCasing.svelte');
345+
346+
const completions = await completionProvider.getCompletions(
347+
document,
348+
Position.create(1, 22),
349+
{
350+
triggerKind: CompletionTriggerKind.TriggerCharacter,
351+
triggerCharacter: '/'
352+
}
353+
);
354+
355+
assert.equal(completions?.items[0].label, 'toImport.ts');
356+
});
357+
343358
it('provides import completions for supported files', async () => {
344359
const sourceFile = 'importcompletions.svelte';
345360
const { completionProvider, document } = setup(sourceFile);
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<script>
2+
import {} from './'
3+
</script>

packages/language-server/test/plugins/typescript/testfiles/completions/UpperCase/toImport.ts

Whitespace-only changes.

0 commit comments

Comments
 (0)