(fix) shorthand transition and animation params (#816)

Fixes #785

Author: bfanger

packages/svelte2tsx/src/htmlxtojsx/nodes/animation-directive.ts

@@ -20,11 +20,7 @@ export function handleAnimateDirective(
     const nodeType = `__sveltets_mapElementTag('${parent.name}')`;
 
     if (!attr.expression) {
-        if (animationsThatNeedParam.has(attr.name)) {
-            str.appendLeft(attr.end, `(${nodeType},__sveltets_AnimationMove,{}))}`);
-        } else {
-            str.appendLeft(attr.end, `(${nodeType},__sveltets_AnimationMove))}`);
-        }
+        str.appendLeft(attr.end, `(${nodeType},__sveltets_AnimationMove,{}))}`);
         return;
     }
     str.overwrite(
@@ -37,16 +33,3 @@ export function handleAnimateDirective(
         str.remove(attr.end - 1, attr.end);
     }
 }
-
-/**
- * Up to Svelte version 3.32.0, the following built-in animate functions have
- * optional parameters, but according to its typings they were mandatory.
- * To not show unnecessary type errors to those users, `{}` should be added
- * as a fallback parameter if the user did not provide one.
- * It may be the case that someone has a custom animation with the same name
- * that expects different parameters, or that someone did an import alias fly as foo,
- * but those are very unlikely.
- *
- * Remove this "hack" some day.
- */
-const animationsThatNeedParam = new Set(['flip']);

packages/svelte2tsx/src/htmlxtojsx/nodes/transition-directive.ts

@@ -25,11 +25,7 @@ export function handleTransitionDirective(
     const nodeType = `__sveltets_mapElementTag('${parent.name}')`;
 
     if (!attr.expression) {
-        if (transitionsThatNeedParam.has(attr.name)) {
-            str.appendLeft(attr.end, `(${nodeType},{}))}`);
-        } else {
-            str.appendLeft(attr.end, `(${nodeType}))}`);
-        }
+        str.appendLeft(attr.end, `(${nodeType},{}))}`);
         return;
     }
 
@@ -43,16 +39,3 @@ export function handleTransitionDirective(
         str.remove(attr.end - 1, attr.end);
     }
 }
-
-/**
- * Up to Svelte version 3.32.0, the following built-in transition functions have
- * optional parameters, but according to its typings they were mandatory.
- * To not show unnecessary type errors to those users, `{}` should be added
- * as a fallback parameter if the user did not provide one.
- * It may be the case that someone has a custom transition with the same name
- * that expects different parameters, or that someone did an import alias fly as foo,
- * but those are very unlikely.
- *
- * Remove this "hack" some day.
- */
-const transitionsThatNeedParam = new Set(['blur', 'fade', 'fly', 'slide', 'scale', 'draw']);

packages/svelte2tsx/test/htmlx2jsx/samples/animation-bare/expected.jsx

@@ -1 +1 @@
-<><h1 {...__sveltets_ensureAnimation(blink(__sveltets_mapElementTag('h1'),__sveltets_AnimationMove))}>Hello</h1></>
+<><h1 {...__sveltets_ensureAnimation(blink(__sveltets_mapElementTag('h1'),__sveltets_AnimationMove,{}))}>Hello</h1></>

packages/svelte2tsx/test/htmlx2jsx/samples/transition-animate-fallbacks/expected.jsx

@@ -11,7 +11,7 @@
 
 <h1 {...__sveltets_ensureAnimation(flip(__sveltets_mapElementTag('h1'),__sveltets_AnimationMove,{}))}>Hello</h1>
 
-<h1 {...__sveltets_ensureTransition(foo(__sveltets_mapElementTag('h1')))}>Hello</h1>
-<h1 {...__sveltets_ensureTransition(foo(__sveltets_mapElementTag('h1')))}>Hello</h1>
-<h1 {...__sveltets_ensureTransition(foo(__sveltets_mapElementTag('h1')))}>Hello</h1>
-<h1 {...__sveltets_ensureAnimation(foo(__sveltets_mapElementTag('h1'),__sveltets_AnimationMove))}>Hello</h1></>
+<h1 {...__sveltets_ensureTransition(foo(__sveltets_mapElementTag('h1'),{}))}>Hello</h1>
+<h1 {...__sveltets_ensureTransition(foo(__sveltets_mapElementTag('h1'),{}))}>Hello</h1>
+<h1 {...__sveltets_ensureTransition(foo(__sveltets_mapElementTag('h1'),{}))}>Hello</h1>
+<h1 {...__sveltets_ensureAnimation(foo(__sveltets_mapElementTag('h1'),__sveltets_AnimationMove,{}))}>Hello</h1></>

packages/svelte2tsx/test/htmlx2jsx/samples/transition-bare/expected.jsx

@@ -1,3 +1,3 @@
-<><h1 {...__sveltets_ensureTransition(blink(__sveltets_mapElementTag('h1')))}>Hello</h1>
-<h1 {...__sveltets_ensureTransition(blink(__sveltets_mapElementTag('h1')))}>Hello</h1>
-<h1 {...__sveltets_ensureTransition(blink(__sveltets_mapElementTag('h1')))}>Hello</h1></>
+<><h1 {...__sveltets_ensureTransition(blink(__sveltets_mapElementTag('h1'),{}))}>Hello</h1>
+<h1 {...__sveltets_ensureTransition(blink(__sveltets_mapElementTag('h1'),{}))}>Hello</h1>
+<h1 {...__sveltets_ensureTransition(blink(__sveltets_mapElementTag('h1'),{}))}>Hello</h1></>