feat: TypeScript 5.7 support (#2585)

* feat: typescript 5.7 support

* bumps to stable

* update svelte 5 snapshot

Author: jasonlyu123

package.json

@@ -13,7 +13,7 @@
         "lint": "prettier --check ."
     },
     "dependencies": {
-        "typescript": "~5.6.3"
+        "typescript": "^5.7.2"
     },
     "devDependencies": {
         "cross-env": "^7.0.2",

packages/language-server/package.json

@@ -62,7 +62,7 @@
         "prettier-plugin-svelte": "^3.3.0",
         "svelte": "^4.2.19",
         "svelte2tsx": "workspace:~",
-        "typescript": "~5.6.3",
+        "typescript": "^5.7.2",
         "typescript-auto-import-cache": "^0.3.5",
         "vscode-css-languageservice": "~6.3.0",
         "vscode-html-languageservice": "~5.3.0",

packages/language-server/src/plugins/typescript/features/CompletionProvider.ts

@@ -807,7 +807,11 @@ export class CompletionsProviderImpl implements CompletionsProvider<CompletionRe
         }
 
         const isNewIdentifierLocation = response.isNewIdentifierLocation;
-        let defaultCommitCharacters = response.defaultCommitCharacters;
+        // TypeScript 5.7+ reused the same array for different completions
+        let defaultCommitCharacters = response.defaultCommitCharacters
+            ? Array.from(response.defaultCommitCharacters)
+            : undefined;
+
         if (!isNewIdentifierLocation) {
             // This actually always exists although it's optional in the type, at least in ts 5.6,
             // so our commit characters are mostly fallback for older ts versions

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/accessors-customElement-configs/input.svelte

@@ -10,6 +10,6 @@
     $: c.abc = a.abc = ao.abc = '';
 </script>
 
-<CustomElement />
-<Accessors />
-<AccessorsAndOption />
+<CustomElement bind:this={c} />
+<Accessors bind:this={a} />
+<AccessorsAndOption bind:this={ao} />

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/checkjs-nostrict/each-anytype/input.svelte

@@ -1,5 +1,10 @@
 <script>
   let anyType;
+
+  async function load() {
+    anyType = (await (await fetch('')).json());
+  }
+  load();
 </script>
 
 {#each anyType as anyEntry}

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/component-invalid/expected_svelte_5.json

@@ -17,7 +17,7 @@
         },
         "severity": 1,
         "source": "ts",
-        "message": "Type 'boolean' is not assignable to type 'never'.",
+        "message": "Type 'true' is not assignable to type 'never'.",
         "code": 2322,
         "tags": []
     },

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/component-invalid/expectedv2.json

@@ -17,7 +17,7 @@
         },
         "severity": 1,
         "source": "ts",
-        "message": "Type 'boolean' is not assignable to type 'never'.",
+        "message": "Type 'true' is not assignable to type 'never'.",
         "code": 2322,
         "tags": []
     },

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/const-tag-if/expectedv2.json

@@ -1,8 +1,8 @@
 [
     {
         "range": {
-            "start": { "line": 21, "character": 19 },
-            "end": { "line": 21, "character": 26 }
+            "start": { "line": 25, "character": 19 },
+            "end": { "line": 25, "character": 26 }
         },
         "severity": 1,
         "source": "ts",
@@ -12,8 +12,8 @@
     },
     {
         "range": {
-            "start": { "line": 21, "character": 40 },
-            "end": { "line": 21, "character": 47 }
+            "start": { "line": 25, "character": 40 },
+            "end": { "line": 25, "character": 47 }
         },
         "severity": 1,
         "source": "ts",
@@ -23,8 +23,8 @@
     },
     {
         "range": {
-            "start": { "line": 23, "character": 11 },
-            "end": { "line": 23, "character": 20 }
+            "start": { "line": 27, "character": 11 },
+            "end": { "line": 27, "character": 20 }
         },
         "severity": 1,
         "source": "ts",
@@ -34,8 +34,8 @@
     },
     {
         "range": {
-            "start": { "line": 25, "character": 11 },
-            "end": { "line": 25, "character": 18 }
+            "start": { "line": 29, "character": 11 },
+            "end": { "line": 29, "character": 18 }
         },
         "severity": 1,
         "source": "ts",

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/const-tag-if/input.svelte

@@ -1,5 +1,9 @@
 <script lang="ts">
     let value: string | number | boolean;
+
+    function handleClick() {
+        value = 'hello';
+    }
 </script>
 
 <!-- valid -->
@@ -9,7 +13,7 @@
 
     <div>{valueStr.substring(0)}{valueStr2.substring(0)}</div>
 
-    <button on:click={() => {valueStr.substring(0)}}></button>
+    <button on:click={() => {valueStr.substring(0) && handleClick()}}></button>
 {:else if typeof value === 'number'}
     {value.toFixed()}
 {/if}
@@ -24,4 +28,4 @@
     {value.substring(0)}
 {:else}
     {value.toFixed()}
-{/if}
+{/if}

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/unInitialized/expectedv2.json

@@ -1,6 +1,22 @@
 [
     {
-        "range": { "start": { "line": 3, "character": 4 }, "end": { "line": 3, "character": 6 } },
+        "range": { "start": { "line": 5, "character": 4 }, "end": { "line": 5, "character": 6 } },
+        "severity": 1,
+        "source": "ts",
+        "message": "Variable 'hi' is used before being assigned.",
+        "code": 2454,
+        "tags": []
+    },
+    {
+        "range": { "start": { "line": 7, "character": 4 }, "end": { "line": 7, "character": 7 } },
+        "severity": 1,
+        "source": "ts",
+        "message": "Variable 'hi3' is used before being assigned.",
+        "code": 2454,
+        "tags": []
+    },
+    {
+        "range": { "start": { "line": 16, "character": 1 }, "end": { "line": 16, "character": 3 } },
         "severity": 1,
         "source": "ts",
         "message": "Variable 'hi' is used before being assigned.",