fix excluded file got added to snapshot manager (#956)

* fix excluded file got added

* test doesn't fail before

Author: jasonlyu123

packages/language-server/src/plugins/typescript/TypeScriptPlugin.ts

@@ -382,10 +382,9 @@ export class TypeScriptPlugin
                 }
             } else if (changeType === FileChangeType.Deleted) {
                 snapshotManager.delete(fileName);
-                return;
+            } else {
+                snapshotManager.updateTsOrJsFile(fileName);
             }
-
-            snapshotManager.updateTsOrJsFile(fileName);
         }
     }
 

packages/language-server/test/plugins/typescript/TypescriptPlugin.test.ts

@@ -431,13 +431,19 @@ describe('TypescriptPlugin', () => {
         assert.equal(secondSnapshot, undefined);
     });
 
-    it('should add snapshot when project file added', async () => {
+    const testForOnWatchedFileAdd = async (filePath: string, shouldExist: boolean) => {
         const { snapshotManager, plugin, targetSvelteFile } = await setupForOnWatchedFileChanges();
-        const addFile = path.join(path.dirname(targetSvelteFile), 'foo.ts');
+        const addFile = path.join(path.dirname(targetSvelteFile), filePath);
         const normalizedAddFilePath = normalizeWatchFilePath(addFile);
 
+        const dir = path.dirname(addFile);
+        if (!fs.existsSync(dir)) {
+            fs.mkdirSync(dir);
+        }
+        fs.writeFileSync(addFile, 'export function abc() {}');
+        assert.ok(fs.existsSync(addFile));
+
         try {
-            fs.writeFileSync(addFile, 'export function abc() {}');
             assert.equal(snapshotManager.has(normalizedAddFilePath), false);
 
             await plugin.onWatchFileChanges([
@@ -447,10 +453,18 @@ describe('TypescriptPlugin', () => {
                 }
             ]);
 
-            assert.equal(snapshotManager.has(normalizedAddFilePath), true);
+            assert.equal(snapshotManager.has(normalizedAddFilePath), shouldExist);
         } finally {
             fs.unlinkSync(addFile);
         }
+    };
+
+    it('should add snapshot when a project file is added', async () => {
+        await testForOnWatchedFileAdd('foo.ts', true);
+    });
+
+    it('should not add snapshot when an excluded file is added', async () => {
+        await testForOnWatchedFileAdd(path.join('dist', 'index.js'), false);
     });
 
     it('should update ts/js file after document change', async () => {

packages/language-server/test/plugins/typescript/testfiles/tsconfig.json

@@ -6,5 +6,9 @@
           because TS does not look up other types.
         */
         "types": ["svelte"]
-    }
+    },
+    "exclude": [
+        /**For testing exclude */
+        "./dist"
+    ]
 }