(fix) dont show redundant onevent completions (#907)

dummdidumm · web-flow · commit 966d4118b53c · 2021-03-23T10:09:38.000+01:00
Svelte wants events of the form "on:X", but the suggestions from the TS language service are of the form "onX". Moreover, they are doubled by the HTML attribute suggestions. Therefore filter them out.
diff --git a/packages/language-server/src/plugins/typescript/features/CompletionProvider.ts b/packages/language-server/src/plugins/typescript/features/CompletionProvider.ts
@@ -476,5 +476,11 @@ function isValidCompletion(
     if (!isCompletionInHTMLStartTag) {
         return () => true;
     }
-    return (value) => !completionBlacklist.has(value.name);
+    return (value) =>
+        !completionBlacklist.has(value.name) &&
+        // remove attribues starting with "on" because those are events.
+        // Svelte wants events of the form "on:X", but the suggestions
+        // are of the form "onX". Moreover, they are doubled by the HTML
+        // attribute suggestions. Therefore filter them out.
+        !value.name.startsWith('on');
 }

Original file line number	Diff line number	Diff line change
`@@ -476,5 +476,11 @@ function isValidCompletion(`
`476`	`476`	`if (!isCompletionInHTMLStartTag) {`
`477`	`477`	`return () => true;`
`478`	`478`	`}`
`479`		`- return (value) => !completionBlacklist.has(value.name);`
	`479`	`+ return (value) =>`
	`480`	`+ !completionBlacklist.has(value.name) &&`
	`481`	`+ // remove attribues starting with "on" because those are events.`
	`482`	`+ // Svelte wants events of the form "on:X", but the suggestions`
	`483`	`+ // are of the form "onX". Moreover, they are doubled by the HTML`
	`484`	`+ // attribute suggestions. Therefore filter them out.`
	`485`	`+ !value.name.startsWith('on');`
`480`	`486`	`}`