(fix) remove overzealous $$Props check (#1920)

The check if exports are assignable to $$Props is removed because a component should be allowed to use less props than defined (it just ignores them)

Author: dummdidumm

packages/language-server/test/plugins/typescript/features/diagnostics/fixtures/$$props-invalid3/expectedv2.json

@@ -6,13 +6,5 @@
         "message": "Argument of type '$$Props' is not assignable to parameter of type '{ wrong: boolean; }'.\n  Property 'wrong' is missing in type '$$Props' but required in type '{ wrong: boolean; }'.",
         "code": 2345,
         "tags": []
-    },
-    {
-        "range": { "start": { "line": 1, "character": 11 }, "end": { "line": 1, "character": 18 } },
-        "severity": 1,
-        "source": "ts",
-        "message": "Argument of type '{ wrong: boolean; }' is not assignable to parameter of type '$$Props'.\n  Object literal may only specify known properties, and 'wrong' does not exist in type '$$Props'.",
-        "code": 2345,
-        "tags": []
     }
 ]

packages/svelte2tsx/src/svelte2tsx/nodes/ExportedNames.ts

@@ -353,21 +353,16 @@ export class ExportedNames {
         if (this.uses$$Props) {
             const lets = names.filter(([, { isLet }]) => isLet);
             const others = names.filter(([, { isLet }]) => !isLet);
-            // We need to check both ways:
-            // - The check if exports are assignable to $$Props is necessary to make sure
-            //   no props are missing. Use Partial<$$Props> in case $$props is used.
             // - The check if $$Props is assignable to exports is necessary to make sure no extraneous props
             //   are defined and that no props are required that should be optional
-            // __sveltets_2_ensureRightProps needs to be declared in a way that doesn't affect the type result of props
+            // - The check if exports are assignable to $$Props is not done because a component should be allowed
+            //   to use less props than defined (it just ignores them)
+            // - __sveltets_2_ensureRightProps needs to be declared in a way that doesn't affect the type result of props
             return (
                 '{...__sveltets_2_ensureRightProps<{' +
                 this.createReturnElementsType(lets).join(',') +
                 '}>(__sveltets_2_any("") as $$Props), ' +
-                '...__sveltets_2_ensureRightProps<' +
-                (uses$$propsOr$$restProps ? 'Partial<$$Props>' : '$$Props') +
-                '>({' +
-                this.createReturnElements(lets, false).join(',') +
-                '}), ...{} as unknown as $$Props, ...{' +
+                '...{} as unknown as $$Props, ...{' +
                 // We add other exports of classes and functions here because
                 // they need to appear in the props object in order to properly
                 // type bind:xx but they are not needed to be part of $$Props

packages/svelte2tsx/test/svelte2tsx/samples/ts-$$Props-interface/expectedv2.ts

@@ -31,7 +31,7 @@
 
 ;
 async () => {};
-return { props: {...__sveltets_2_ensureRightProps<{exported1: string,exported2?: string,name1?: string,name2: string,renamed1?: string,renamed2: string}>(__sveltets_2_any("") as $$Props), ...__sveltets_2_ensureRightProps<$$Props>({exported1: exported1,exported2: exported2,name1: name1,name2: name2,renamed1: rename1,renamed2: rename2}), ...{} as unknown as $$Props, ...{Foo: Foo, bar: bar, baz: baz, RenamedFoo: RenameFoo, renamedbar: renamebar, renamedbaz: renamebaz} as {Foo?: typeof Foo,bar?: typeof bar,baz?: string,RenamedFoo?: typeof RenameFoo,renamedbar?: typeof renamebar,renamedbaz?: string}}, slots: {}, events: {} }}
+return { props: {...__sveltets_2_ensureRightProps<{exported1: string,exported2?: string,name1?: string,name2: string,renamed1?: string,renamed2: string}>(__sveltets_2_any("") as $$Props), ...{} as unknown as $$Props, ...{Foo: Foo, bar: bar, baz: baz, RenamedFoo: RenameFoo, renamedbar: renamebar, renamedbaz: renamebaz} as {Foo?: typeof Foo,bar?: typeof bar,baz?: string,RenamedFoo?: typeof RenameFoo,renamedbar?: typeof renamebar,renamedbaz?: string}}, slots: {}, events: {} }}
 
 export default class Input__SvelteComponent_ extends __sveltets_2_createSvelte2TsxComponent(__sveltets_2_with_any_event(render())) {
 }

packages/svelte2tsx/test/svelte2tsx/samples/ts-$$Props-type/expectedv2.ts

@@ -31,7 +31,7 @@
 
 ;
 async () => {};
-return { props: {...__sveltets_2_ensureRightProps<{exported1: string,exported2?: string,name1?: string,name2: string,renamed1?: string,renamed2: string}>(__sveltets_2_any("") as $$Props), ...__sveltets_2_ensureRightProps<$$Props>({exported1: exported1,exported2: exported2,name1: name1,name2: name2,renamed1: rename1,renamed2: rename2}), ...{} as unknown as $$Props, ...{Foo: Foo, bar: bar, baz: baz, RenamedFoo: RenameFoo, renamedbar: renamebar, renamedbaz: renamebaz} as {Foo?: typeof Foo,bar?: typeof bar,baz?: string,RenamedFoo?: typeof RenameFoo,renamedbar?: typeof renamebar,renamedbaz?: string}}, slots: {}, events: {} }}
+return { props: {...__sveltets_2_ensureRightProps<{exported1: string,exported2?: string,name1?: string,name2: string,renamed1?: string,renamed2: string}>(__sveltets_2_any("") as $$Props), ...{} as unknown as $$Props, ...{Foo: Foo, bar: bar, baz: baz, RenamedFoo: RenameFoo, renamedbar: renamebar, renamedbaz: renamebaz} as {Foo?: typeof Foo,bar?: typeof bar,baz?: string,RenamedFoo?: typeof RenameFoo,renamedbar?: typeof renamebar,renamedbaz?: string}}, slots: {}, events: {} }}
 
 export default class Input__SvelteComponent_ extends __sveltets_2_createSvelte2TsxComponent(__sveltets_2_with_any_event(render())) {
 }

packages/svelte2tsx/test/svelte2tsx/samples/ts-$$Props-with-$$props/expectedv2.ts

@@ -13,7 +13,7 @@
 async () => {
 
 $$props;};
-return { props: {...__sveltets_2_ensureRightProps<{}>(__sveltets_2_any("") as $$Props), ...__sveltets_2_ensureRightProps<Partial<$$Props>>({}), ...{} as unknown as $$Props, ...{c: c} as {c?: typeof c}}, slots: {}, events: {} }}
+return { props: {...__sveltets_2_ensureRightProps<{}>(__sveltets_2_any("") as $$Props), ...{} as unknown as $$Props, ...{c: c} as {c?: typeof c}}, slots: {}, events: {} }}
 
 export default class Input__SvelteComponent_ extends __sveltets_2_createSvelte2TsxComponent(__sveltets_2_with_any_event(render())) {
     get c() { return __sveltets_2_nonNullable(this.$$prop_def.c) }