(fix) don't remove inserted code around comment (#935)

dummdidumm · web-flow · commit fd7865be09b2 · 2021-04-06T08:14:14.000+02:00
Use overwrite instead of remove #928
diff --git a/packages/svelte2tsx/src/htmlxtojsx/nodes/comment.ts b/packages/svelte2tsx/src/htmlxtojsx/nodes/comment.ts
@@ -5,5 +5,5 @@ import { BaseNode } from '../../interfaces';
  * Removes comment
  */
 export function handleComment(str: MagicString, node: BaseNode): void {
-    str.remove(node.start, node.end);
+    str.overwrite(node.start, node.end, '', { contentOnly: true });
 }
diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/comments-around-if/expected.jsx b/packages/svelte2tsx/test/htmlx2jsx/samples/comments-around-if/expected.jsx
@@ -0,0 +1 @@
+<><div>{(true) ? <><span>Hey!</span></> : (!true) ? <><span>there...</span></> : <></> }</div></>
diff --git a/packages/svelte2tsx/test/htmlx2jsx/samples/comments-around-if/input.svelte b/packages/svelte2tsx/test/htmlx2jsx/samples/comments-around-if/input.svelte
@@ -0,0 +1,7 @@
+<div><!--
+-->{#if true}<!--
+   --><span>Hey!</span><!--
+-->{:else if !true}<!--
+   --><span>there...</span><!--
+-->{/if}<!--
+--></div>

Original file line number	Diff line number	Diff line change
`@@ -5,5 +5,5 @@ import { BaseNode } from '../../interfaces';`
`5`	`5`	`* Removes comment`
`6`	`6`	`*/`
`7`	`7`	`export function handleComment(str: MagicString, node: BaseNode): void {`
`8`		`- str.remove(node.start, node.end);`
	`8`	`+ str.overwrite(node.start, node.end, '', { contentOnly: true });`
`9`	`9`	`}`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<><div>{(true) ? <><span>Hey!</span></> : (!true) ? <><span>there...</span></> : <></> }</div></>`