Skip to content

Commit 14da6fb

Browse files
authored
(fix) respect strict mode and shorthand options when formatting bindings (#325)
Fixes #321
1 parent 7cfd71b commit 14da6fb

File tree

7 files changed

+29
-1
lines changed

7 files changed

+29
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
## 2.8.1 (Unreleased)
44

55
* (fix) format `{#await .. catch ..}..{/await}` correctly ([#323](https://github.com/sveltejs/prettier-plugin-svelte/issues/323))
6+
* (fix) respect strict mode and shorthand options when formatting bindings ([#321](https://github.com/sveltejs/prettier-plugin-svelte/issues/321))
67

78
## 2.8.0
89

src/print/index.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -608,7 +608,10 @@ export function print(path: FastPath, options: ParserOptions, print: PrintFn): D
608608
return concat([
609609
'bind:',
610610
node.name,
611-
node.expression.type === 'Identifier' && node.expression.name === node.name
611+
node.expression.type === 'Identifier' &&
612+
node.expression.name === node.name &&
613+
options.svelteAllowShorthand &&
614+
!options.svelteStrictMode
612615
? ''
613616
: concat(['=', ...printJsExpression()]),
614617
]);
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<input value />
2+
<input value="string" />
3+
<input {value} />
4+
<input value={value} />
5+
<input value="{value}" />
6+
<input bind:value />
7+
<input bind:value={value} />
8+
<input bind:value="{value}" />
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
<input value />
2+
<input value="string" />
3+
<input {value} />
4+
<input {value} />
5+
<input {value} />
6+
<input bind:value />
7+
<input bind:value />
8+
<input bind:value />

test/formatting/samples/strict-mode-true/input.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,6 @@
33
<input {value} />
44
<input value={value} />
55
<input value="{value}" />
6+
<input bind:value />
7+
<input bind:value={value} />
8+
<input bind:value="{value}" />

test/formatting/samples/strict-mode-true/output.html

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,3 +3,6 @@
33
<input value="{value}" />
44
<input value="{value}" />
55
<input value="{value}" />
6+
<input bind:value="{value}" />
7+
<input bind:value="{value}" />
8+
<input bind:value="{value}" />
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
<input type="text" value={value} />
22

33
<input type="text" data={data} />
4+
5+
<input type="text" bind:value={value} />

0 commit comments

Comments
 (0)