fix: handle static tag attribute on svelte:element

dummdidumm · dummdidumm · commit 6fc0b64f3b90 · 2023-07-27T18:12:46.000+02:00
fixes #395
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # prettier-plugin-svelte changelog
 
+## 3.0.3
+
+-   (fix) handle static `tag` attributes on `<svelte:element>`
+
 ## 3.0.2
 
 -   (fix) add `package.json` to exports map
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "prettier-plugin-svelte",
-    "version": "3.0.2",
+    "version": "3.0.3",
     "description": "Svelte plugin for prettier",
     "main": "plugin.js",
     "files": [
diff --git a/src/embed.ts b/src/embed.ts
@@ -352,7 +352,7 @@ function printJS(
     removeParentheses: boolean,
     name: string,
 ) {
-    if (!node[name]) {
+    if (!node[name] || typeof node[name] !== 'object') {
         return;
     }
     node[name].isJS = true;
diff --git a/test/printer/samples/svelte-element-static-tag.html b/test/printer/samples/svelte-element-static-tag.html
@@ -0,0 +1 @@
+<svelte:element this="slot" bind:this={slot} />

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "prettier-plugin-svelte",`
`3`		`- "version": "3.0.2",`
	`3`	`+ "version": "3.0.3",`
`4`	`4`	`"description": "Svelte plugin for prettier",`
`5`	`5`	`"main": "plugin.js",`
`6`	`6`	`"files": [`
Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ function printJS(`
`352`	`352`	`removeParentheses: boolean,`
`353`	`353`	`name: string,`
`354`	`354`	`) {`
`355`		`- if (!node[name]) {`
	`355`	`+ if (!node[name] \|\| typeof node[name] !== 'object') {`
`356`	`356`	`return;`
`357`	`357`	`}`
`358`	`358`	`node[name].isJS = true;`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+<svelte:element this="slot" bind:this={slot} />`