Skip to content

Commit 6242398

Browse files
authored
chore(repl): Static adapter (#525)
* Push * Fix accessibility issues
1 parent 41e7955 commit 6242398

File tree

10 files changed

+35
-28
lines changed

10 files changed

+35
-28
lines changed

packages/repl/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
],
3737
"scripts": {
3838
"dev": "vite dev",
39-
"build": "vite build && npm run package",
39+
"build": "vite build",
4040
"preview": "vite preview",
4141
"package": "svelte-kit sync && svelte-package && publint",
4242
"package:watch": "svelte-package --watch",
@@ -49,7 +49,7 @@
4949
},
5050
"devDependencies": {
5151
"@fontsource/fira-mono": "^5.0.3",
52-
"@sveltejs/adapter-auto": "^2.1.0",
52+
"@sveltejs/adapter-static": "^2.0.2",
5353
"@sveltejs/kit": "^1.20.5",
5454
"@sveltejs/package": "^2.1.0",
5555
"@types/marked": "^5.0.0",

packages/repl/src/lib/CodeMirror.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
/** @type {import('./types').StartOrEnd | null} */
1616
export let errorLoc = null;
1717
18-
/** @type {import('@codemirror/lint').LintSource} */
19-
export let diagnostics;
18+
/** @type {import('@codemirror/lint').LintSource | undefined} */
19+
export let diagnostics = undefined;
2020
2121
export let readonly = false;
2222
export let tab = true;

packages/repl/src/lib/Input/ComponentSelector.svelte

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@
204204
205205
<div class="component-selector">
206206
{#if $files.length}
207+
<!-- svelte-ignore a11y-no-static-element-interactions -->
207208
<div class="file-tabs" on:dblclick={add_new}>
208209
{#each $files as file, index (file.name)}
209210
{@const filename = get_full_filename(file)}
@@ -256,6 +257,7 @@
256257
/>
257258
{/if}
258259
{:else}
260+
<!-- svelte-ignore a11y-no-static-element-interactions -->
259261
<div
260262
class="editable"
261263
title="edit component name"
@@ -265,6 +267,7 @@
265267
{file.name}.{file.type}{#if show_modified && file.modified}*{/if}
266268
</div>
267269
270+
<!-- svelte-ignore a11y-no-static-element-interactions -->
268271
<span
269272
class="remove"
270273
on:click={() => remove(filename)}

packages/repl/src/lib/Message.svelte

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,15 @@
2929
}
3030
</script>
3131

32-
<div transition:slide|local={{ duration: 100 }} class="message {kind}" class:truncate>
32+
<div transition:slide={{ duration: 100 }} class="message {kind}" class:truncate>
3333
{#if details}
34-
<p
34+
<button
3535
class:navigable={details.filename}
3636
on:click={() => go_to_warning_pos(details)}
3737
on:keyup={(e) => e.key === ' ' && go_to_warning_pos(details)}
3838
>
3939
{message(details)}
40-
</p>
40+
</button>
4141
{:else}
4242
<slot />
4343
{/if}
@@ -81,8 +81,9 @@
8181
text-overflow: ellipsis;
8282
}
8383
84-
p {
84+
button {
8585
margin: 0;
86+
text-align: start;
8687
}
8788
8889
.error {

packages/repl/src/lib/Output/Output.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
3838
/**
3939
* @param {import('$lib/types').File} file
40-
* @param {import('svelte/types/compiler').CompileOptions} options
40+
* @param {import('svelte/compiler').CompileOptions} options
4141
*/
4242
export async function set(file, options) {
4343
selected_type = file.type;
@@ -65,7 +65,7 @@
6565
6666
/**
6767
* @param {import('$lib/types').File} selected
68-
* @param {import('svelte/types/compiler').CompileOptions} options
68+
* @param {import('svelte/compiler').CompileOptions} options
6969
*/
7070
export async function update(selected, options) {
7171
if (/(js|json)/.test(selected.type)) return;

packages/repl/src/lib/Output/PaneWithPanel.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,10 +45,10 @@
4545
</section>
4646

4747
<section slot="b">
48-
<div class="panel-header" on:click={toggle} on:keyup={(e) => e.key === ' ' && toggle()}>
48+
<button class="panel-header" on:click={toggle}>
4949
<span class="panel-heading">{panel}</span>
5050
<slot name="panel-header" />
51-
</div>
51+
</button>
5252

5353
<div class="panel-body">
5454
<slot name="panel-body" />

packages/repl/src/lib/Output/console/ConsoleLine.svelte

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -15,25 +15,19 @@
1515
<ConsoleTable data={log.args[0]} columns={log.args[1]} />
1616
{/if}
1717

18-
<div
18+
<button
1919
class="log console-{log.level}"
2020
style="padding-left: {level * 15}px"
2121
on:click={log.level === 'group' ? toggle_group_collapse : undefined}
22-
on:keyup={(e) => (e.key === ' ' && log.level === 'group' ? toggle_group_collapse() : undefined)}
2322
>
2423
{#if log.count && log.count > 1}
2524
<span class="count">{log.count}x</span>
2625
{/if}
2726

2827
{#if log.level === 'trace' || log.level === 'assert'}
29-
<div
30-
class="arrow"
31-
class:expand={!log.collapsed}
32-
on:click={toggle_group_collapse}
33-
on:keyup={(e) => e.key === ' ' && toggle_group_collapse()}
34-
>
28+
<button class="arrow" class:expand={!log.collapsed} on:click={toggle_group_collapse}>
3529
36-
</div>
30+
</button>
3731
{/if}
3832

3933
{#if log.level === 'assert'}
@@ -61,7 +55,7 @@
6155
{#each new Array(level - 1) as _, idx}
6256
<div class="outline" style="left: {idx * 15 + 15}px" />
6357
{/each}
64-
</div>
58+
</button>
6559

6660
{#if log.level === 'group' && !log.collapsed}
6761
{#each log.logs ?? [] as childLog}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
export const prerender = true;

packages/repl/svelte.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import adapter from '@sveltejs/adapter-auto';
1+
import adapter from '@sveltejs/adapter-static';
22

33
/** @type {import('@sveltejs/kit').Config} */
44
export default {
55
kit: {
6-
adapter: adapter()
6+
adapter: adapter({})
77
}
88
};

pnpm-lock.yaml

Lines changed: 12 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)