more

Author: baseballyama

src/parser/converts/attr.ts

@@ -49,6 +49,7 @@ export function* convertAttributes(
     | SvAST.AttributeOrDirective
     | Compiler.Attribute
     | Compiler.SpreadAttribute
+    | Compiler.AttachTag
     | Compiler.Directive
   )[],
   parent: SvelteStartTag,

src/parser/converts/element.ts

@@ -223,13 +223,19 @@ export function* convertChildren(
 function extractLetDirectives(fragment: {
   attributes:
     | SvAST.AttributeOrDirective[]
-    | (Compiler.Attribute | Compiler.SpreadAttribute | Compiler.Directive)[];
+    | (
+        | Compiler.Attribute
+        | Compiler.SpreadAttribute
+        | Compiler.AttachTag
+        | Compiler.Directive
+      )[];
 }): {
   letDirectives: (SvAST.LetDirective | Compiler.LetDirective)[];
   attributes: Exclude<
     | SvAST.AttributeOrDirective
     | Compiler.Attribute
     | Compiler.SpreadAttribute
+    | Compiler.AttachTag
     | Compiler.Directive,
     SvAST.LetDirective | Compiler.LetDirective
   >[];
@@ -239,6 +245,7 @@ function extractLetDirectives(fragment: {
     | SvAST.AttributeOrDirective
     | Compiler.Attribute
     | Compiler.SpreadAttribute
+    | Compiler.AttachTag
     | Compiler.Directive,
     SvAST.LetDirective | Compiler.LetDirective
   >[] = [];

src/parser/svelte-ast-types.ts

@@ -212,7 +212,6 @@ export interface AttachTag extends BaseNode {
 export type AttributeOrDirective =
   | Attribute
   | Spread
-  | AttachTag
   | Directive
   | StyleDirective;
 

src/visitor-keys.ts

@@ -42,6 +42,7 @@ const svelteKeys: SvelteKeysType = {
   SvelteAttribute: ["key", "value"],
   SvelteShorthandAttribute: ["key", "value"],
   SvelteSpreadAttribute: ["argument"],
+  SvelteAttachTag: ["expression"],
   SvelteDirective: ["key", "expression"],
   SvelteStyleDirective: ["key", "value"],
   SvelteSpecialDirective: ["key", "expression"],

tests/fixtures/parser/ast/svelte5/attach04-input.svelte

@@ -0,0 +1,9 @@
+<script>
+	/** @type {import('svelte/elements').HTMLButtonAttributes} */
+	let { children, ...props } = $props();
+</script>
+
+<!-- `props` includes attachments -->
+<button {...props}>
+	{@render children?.()}
+</button>