Skip to content

Commit 6e3369d

Browse files
committed
rename, fix
1 parent 005a1d4 commit 6e3369d

File tree

4 files changed

+9
-18
lines changed

4 files changed

+9
-18
lines changed

apps/svelte.dev/src/lib/components/SelectIcon.svelte renamed to apps/svelte.dev/src/lib/components/ModalDropdown.svelte

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@
8686
</details>
8787

8888
<style>
89-
.examples-select {
89+
details {
9090
position: relative;
9191
9292
&:has(:focus-visible) .raised.icon {
@@ -99,15 +99,6 @@
9999
}
100100
}
101101
102-
select {
103-
opacity: 0.0001;
104-
position: absolute;
105-
top: 0;
106-
left: 0;
107-
width: 100%;
108-
height: 100%;
109-
}
110-
111102
summary {
112103
display: flex;
113104
align-items: center;

apps/svelte.dev/src/routes/(authed)/playground/[id]/AppControls.svelte

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
<script lang="ts">
22
import { page } from '$app/stores';
3-
import { goto } from '$app/navigation';
43
import UserMenu from './UserMenu.svelte';
54
import { Icon } from '@sveltejs/site-kit/components';
65
import { isMac } from '$lib/utils/compat.js';
76
import { get_app_context } from '../../app-context';
87
import type { Gist, User } from '$lib/db/types';
98
import { browser } from '$app/environment';
10-
import SelectIcon from '$lib/components/SelectIcon.svelte';
9+
import ModalDropdown from '$lib/components/ModalDropdown.svelte';
1110
import { untrack } from 'svelte';
1211
import SecondaryNav from '$lib/components/SecondaryNav.svelte';
1312
import type { File } from 'editor';
@@ -40,7 +39,7 @@
4039
let saving = $state(false);
4140
let justSaved = $state(false);
4241
let justForked = $state(false);
43-
let select: ReturnType<typeof SelectIcon>;
42+
let select: ReturnType<typeof ModalDropdown>;
4443
4544
function wait(ms: number) {
4645
return new Promise((f) => setTimeout(f, ms));
@@ -181,7 +180,7 @@
181180
<svelte:window on:keydown={handleKeydown} />
182181

183182
<SecondaryNav>
184-
<SelectIcon label="Examples">
183+
<ModalDropdown label="Examples">
185184
<div class="secondary-nav-dropdown">
186185
<a class="create-new" href="/playground/untitled">Create new</a>
187186

@@ -214,7 +213,7 @@
214213
{/each}
215214
</optgroup>
216215
{/each} -->
217-
</SelectIcon>
216+
</ModalDropdown>
218217

219218
<input
220219
bind:value={name}

apps/svelte.dev/src/routes/tutorial/[...slug]/Controls.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<script lang="ts">
22
import { page } from '$app/stores';
33
import SecondaryNav from '$lib/components/SecondaryNav.svelte';
4-
import SelectIcon from '$lib/components/SelectIcon.svelte';
4+
import ModalDropdown from '$lib/components/ModalDropdown.svelte';
55
import type { Exercise, PartStub } from '$lib/tutorial';
66
import { Icon } from '@sveltejs/site-kit/components';
77
@@ -16,7 +16,7 @@
1616
</script>
1717

1818
<SecondaryNav>
19-
<SelectIcon label="Menu">
19+
<ModalDropdown label="Menu">
2020
<div class="secondary-nav-dropdown">
2121
{#each index as part}
2222
<details>
@@ -43,7 +43,7 @@
4343
</details>
4444
{/each}
4545
</div>
46-
</SelectIcon>
46+
</ModalDropdown>
4747

4848
<a
4949
href={exercise.prev ? `/tutorial/${exercise.prev?.slug}` : undefined}

packages/site-kit/src/lib/styles/utils/nav.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
.secondary-nav-dropdown {
22
max-height: 50rem;
33
width: 30rem;
4+
max-width: calc(100vw - 2 * var(--sk-page-padding-side) - 2rem);
45
font: var(--sk-font-ui-medium);
56

67
details {

0 commit comments

Comments
 (0)