docs: links to types are missing

[benmccann]

Describe the bug

https://kit.svelte.dev/docs/modules#$app-stores-page doesn't have a link to the types it uses

However, it used to: https://web.archive.org/web/20230708065835/https://kit.svelte.dev/docs/modules#$app-stores-page

Reproduction

https://kit.svelte.dev/docs/modules#$app-stores-page

Logs

No response

System Info

n/a

Severity

serious, but I can work around it

Additional Information

No response

[Rishab49]

@benmccann Looks like it is the case with every link present in the code snippets of docs, now types appears on hover. Perhaps these changes were deliberately made by someone.

[benmccann]

Yeah. Whether it was intentional or not, it's much worse and I think we should go back. The biggest issue is that the hover doesn't give you any indication of what members are available on the type. Compare to the info at https://kit.svelte.dev/docs/types#public-types-page

Another issue is that the hover is a single line, which would be difficult enough to read, but then it extends so far that it renders on top of the "on this page" making it even more difficult to read. It's possible that we could fix this to be a multi-line hover that would be present in addition to the link, which might be a way to have our cake and eat it too.

[benmccann]

This has gotten worse with the new site as both the link and hover are gone now

[teemingc]

The logic should be here according to the comment but it may have been removed somehow

svelte.dev/packages/site-kit/src/lib/markdown/renderer.ts

Line 138 in 9732d3b

* - Type links -> Type names are converted to links to the type's documentation page.

[jycouet]

Yes @teemingc it's close to this ;)

Something like this @benmccann ?

That would link to https://svelte.dev/docs/kit/$app-server#getRequestEvent ?

I'm asking because links in the original issue are a bit outdated ^^

[teemingc]

I think it's probably more like the below where the types in the code blocks become underlined links you can click:

This might be nice to also have in the hovered tooltips