pagination component and minor visual tweaks to registry #1200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TGlide is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Conduitry
reviewed
Mar 17, 2025
| const current_results = search(query, { tags, sort_by: 'popularity' }); | ||
|
|
||
| const total_pages = Math.ceil(current_results.length / REGISTRY_PAGE_LIMIT); | ||
| console.log(page, total_pages); |
|
WTH. I did git push from zed and it merged this 💀💀 |
|
So Sorry. The changes look good man. Just one thing, we should show a input when you click on the ... in pagination to jump to a specific page. Also, pagination should be on the left I feel. All controls fixed in one place, only the list being scrollable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.