fix: prevent the tutorial erroring after navigating #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Workspace.reset` method was changed in a non-backward compatible way in commit eb1eb2b, which caused the call in the tutorial pages to not pass the proper value for the selected file. This was missed because the tutorial page didn't use `PageProps` for typing.
|
@zqianem is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
The language server infers this automatically, turns out
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
|
Thank you! |
teemingc
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Workspace.resetmethod was changed in a non-backward compatible way in commit eb1eb2b, which caused the call in the tutorial pages to not pass the proper value for the selected file. This was missed because the tutorial page didn't usePagePropsfor typing.Fixes #1287
Supersedes #1297People going through the tutorial are most likely to first run into this on https://svelte.dev/tutorial/svelte/nested-components — select
Nested.svelteand then advance to the next page.Notably, this doesn't address #868 or #1164, which are caused by a separate issue but have similar symptoms.
Edit: something like #1297 is the proper fix for #868 and #1164
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.