From 2957aacec91dc61bfde4b7338b72e1c80cac300f Mon Sep 17 00:00:00 2001
From: Rich Harris <rich.harris@vercel.com>
Date: Tue, 24 Sep 2024 16:11:33 -0400
Subject: [PATCH 1/2] make docs dropdown more accessible

---
 .../src/lib/components/LinksDropdown.svelte   | 50 ++++++++-----------
 packages/site-kit/src/lib/nav/Nav.svelte      | 17 ++++---
 2 files changed, 31 insertions(+), 36 deletions(-)

diff --git a/packages/site-kit/src/lib/components/LinksDropdown.svelte b/packages/site-kit/src/lib/components/LinksDropdown.svelte
index d23114f9ff..45b960982f 100644
--- a/packages/site-kit/src/lib/components/LinksDropdown.svelte
+++ b/packages/site-kit/src/lib/components/LinksDropdown.svelte
@@ -24,48 +24,40 @@
 	.dropdown {
 		position: relative;
 		display: inline-block;
+		height: 100%;
 	}
 
 	.dropdown-content {
 		display: none;
 		position: absolute;
 		left: -1rem;
-		background-color: var(--sk-back-1);
+		top: calc(100% - 1rem);
+		background-color: var(--sk-back-2);
 		min-width: 10rem;
 		z-index: 1;
-		animation: flyout 0.3s ease-in-out;
 		box-shadow: var(--sk-shadow);
-		border-radius: 0 0 var(--sk-border-radius) var(--sk-border-radius);
-	}
-
-	@keyframes flyout {
-		from {
-			opacity: 0;
-			transform: translateY(-10px);
-		}
-		to {
-			opacity: 1;
-			transform: translateY(0);
+		border-radius: var(--sk-border-radius);
+
+		a {
+			color: var(--sk-text-3);
+			padding: 1.3rem !important;
+			text-decoration: none;
+			display: block;
+			margin: 0 !important;
+			box-shadow: none !important;
+
+			&:last-of-type {
+				border-radius: var(--sk-border-radius);
+			}
 		}
-	}
-
-	.dropdown:hover .dropdown-content {
-		display: block;
-	}
 
-	.dropdown-content a {
-		color: var(--sk-text-3);
-		padding: 1.3rem;
-		text-decoration: none;
-		display: block;
-		margin: 0 !important;
-
-		&:last-of-type {
-			border-radius: 0 0 var(--sk-border-radius) var(--sk-border-radius);
+		a:hover {
+			background-color: var(--sk-back-4);
 		}
 	}
 
-	.dropdown-content a:hover {
-		background-color: var(--sk-back-4);
+	.dropdown:hover .dropdown-content,
+	.dropdown:focus-within .dropdown-content {
+		display: block;
 	}
 </style>
diff --git a/packages/site-kit/src/lib/nav/Nav.svelte b/packages/site-kit/src/lib/nav/Nav.svelte
index f681fa670d..3520a37faa 100644
--- a/packages/site-kit/src/lib/nav/Nav.svelte
+++ b/packages/site-kit/src/lib/nav/Nav.svelte
@@ -207,17 +207,21 @@ Top navigation bar for the application. It provides a slot for the left side, th
 	.menu :global(a) {
 		color: var(--sk-text-2);
 		line-height: 1;
-		margin: 0 0.3em;
+		padding: 0 0.3em;
 		white-space: nowrap;
+		height: 100%;
+		display: flex;
+		align-items: center;
+		text-decoration: none;
+
+		&:hover {
+			box-shadow: inset 0 -1px 0 0 var(--sk-back-5);
+		}
 	}
 
 	.menu :global(a[aria-current='page']) {
 		color: var(--sk-theme-1);
-		box-shadow: inset 0 -1px 0 0 var(--sk-theme-1);
-	}
-
-	.menu :global(a[aria-current='page']:hover) {
-		text-decoration: none;
+		box-shadow: inset 0 -1px 0 0 currentColor;
 	}
 
 	.home-link {
@@ -231,7 +235,6 @@ Top navigation bar for the application. It provides a slot for the left side, th
 		align-items: center;
 		padding-left: calc(var(--sk-page-padding-side) + 4rem);
 		padding-top: 5px; /* center vertically relative to logo */
-		text-decoration: none;
 		text-transform: uppercase;
 		letter-spacing: 0.05em;
 		font-size: 1.8rem;

From 5050afa429f4a28ffb552376ae84ebdbdffcdff5 Mon Sep 17 00:00:00 2001
From: Rich Harris <rich.harris@vercel.com>
Date: Tue, 24 Sep 2024 16:14:48 -0400
Subject: [PATCH 2/2] fix reverse tabbing

---
 packages/site-kit/src/lib/components/LinksDropdown.svelte | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/packages/site-kit/src/lib/components/LinksDropdown.svelte b/packages/site-kit/src/lib/components/LinksDropdown.svelte
index 45b960982f..208b69ae19 100644
--- a/packages/site-kit/src/lib/components/LinksDropdown.svelte
+++ b/packages/site-kit/src/lib/components/LinksDropdown.svelte
@@ -28,7 +28,8 @@
 	}
 
 	.dropdown-content {
-		display: none;
+		opacity: 0;
+		pointer-events: none;
 		position: absolute;
 		left: -1rem;
 		top: calc(100% - 1rem);
@@ -58,6 +59,7 @@
 
 	.dropdown:hover .dropdown-content,
 	.dropdown:focus-within .dropdown-content {
-		display: block;
+		opacity: 1;
+		pointer-events: all;
 	}
 </style>