Skip to content

Commit 0128df3

Browse files
authored
fix: don't add scoping modifier to nesting selectors (#11713)
1 parent a17e84b commit 0128df3

File tree

5 files changed

+22
-9
lines changed

5 files changed

+22
-9
lines changed

.changeset/itchy-beds-kneel.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: don't add scoping modifier to nesting selectors

packages/svelte/src/compiler/phases/3-transform/css/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ const visitors = {
238238
}
239239
}
240240

241-
if (relative_selector.selectors.every((s) => s.type === 'NestingSelector')) {
241+
if (relative_selector.selectors.some((s) => s.type === 'NestingSelector')) {
242242
continue;
243243
}
244244

packages/svelte/tests/css/samples/nested-css/_config.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,29 +75,29 @@ export default test({
7575
{
7676
code: 'css_unused_selector',
7777
end: {
78-
character: 634,
78+
character: 668,
7979
column: 5,
80-
line: 66
80+
line: 70
8181
},
8282
message: 'Unused CSS selector "&.b"',
8383
start: {
84-
character: 631,
84+
character: 665,
8585
column: 2,
86-
line: 66
86+
line: 70
8787
}
8888
},
8989
{
9090
code: 'css_unused_selector',
9191
end: {
92-
character: 666,
92+
character: 700,
9393
column: 9,
94-
line: 70
94+
line: 74
9595
},
9696
message: 'Unused CSS selector ".unused"',
9797
start: {
98-
character: 659,
98+
character: 693,
9999
column: 2,
100-
line: 70
100+
line: 74
101101
}
102102
}
103103
]

packages/svelte/tests/css/samples/nested-css/expected.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,10 @@
3636
}*/
3737
}
3838

39+
&:hover {
40+
color: green;
41+
}
42+
3943
& & {
4044
color: green;
4145
}

packages/svelte/tests/css/samples/nested-css/input.svelte

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,10 @@
5050
}
5151
}
5252
53+
&:hover {
54+
color: green;
55+
}
56+
5357
& & {
5458
color: green;
5559
}

0 commit comments

Comments
 (0)