fix: ensure typings for <svelte:options> are picked up (Svelte 5 version) (#12903)

dummdidumm · web-flow · commit 0da4116b9db5 · 2024-08-19T14:51:45.000+02:00
fixes #12886
diff --git a/.changeset/brown-radios-itch.md b/.changeset/brown-radios-itch.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: ensure typings for `<svelte:options>` are picked up
diff --git a/packages/svelte/svelte-html.d.ts b/packages/svelte/svelte-html.d.ts
@@ -243,8 +243,8 @@ declare global {
 			'svelte:body': HTMLProps<'svelte:body', HTMLAttributes>;
 			'svelte:document': HTMLProps<'svelte:document', HTMLAttributes>;
 			'svelte:fragment': { slot?: string };
-			'svelte:options': HTMLProps<'svelte:options', HTMLAttributes>;
 			'svelte:head': { [name: string]: any };
+			// don't type svelte:options, it would override the types in svelte/elements and it isn't extendable anyway
 
 			[name: string]: { [name: string]: any };
 		}

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: ensure typings for `<svelte:options>` are picked up
Original file line number	Diff line number	Diff line change
`@@ -243,8 +243,8 @@ declare global {`
`243`	`243`	`'svelte:body': HTMLProps<'svelte:body', HTMLAttributes>;`
`244`	`244`	`'svelte:document': HTMLProps<'svelte:document', HTMLAttributes>;`
`245`	`245`	`'svelte:fragment': { slot?: string };`
`246`		`- 'svelte:options': HTMLProps<'svelte:options', HTMLAttributes>;`
`247`	`246`	`'svelte:head': { [name: string]: any };`
	`247`	`+ // don't type svelte:options, it would override the types in svelte/elements and it isn't extendable anyway`
`248`	`248`
`249`	`249`	`[name: string]: { [name: string]: any };`
`250`	`250`	`}`