Skip to content

Commit 118e9aa

Browse files
committed
put flushSync calls on single line — makes it easier to connect the event with the subsequent assertion
1 parent 35e4023 commit 118e9aa

File tree

9 files changed

+36
-105
lines changed

9 files changed

+36
-105
lines changed

packages/svelte/tests/runtime-runes/samples/state-onchange-accumulated/_config.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,10 @@ export default test({
55
async test({ assert, target, logs }) {
66
const [btn, btn2] = target.querySelectorAll('button');
77

8-
flushSync(() => {
9-
btn.click();
10-
});
8+
flushSync(() => btn.click());
119
assert.deepEqual(logs, ['foo', 'baz']);
1210

13-
flushSync(() => {
14-
btn2.click();
15-
});
11+
flushSync(() => btn2.click());
1612
assert.deepEqual(logs, ['foo', 'baz', 'foo', 'baz']);
1713
}
1814
});

packages/svelte/tests/runtime-runes/samples/state-onchange-array-length-batch/_config.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,10 @@ export default test({
55
async test({ assert, target, logs }) {
66
const [btn, btn2] = target.querySelectorAll('button');
77

8-
flushSync(() => {
9-
btn.click();
10-
});
8+
flushSync(() => btn.click());
119
assert.deepEqual(logs, [[{}, {}, {}, {}, {}, {}, {}, {}]]);
1210

13-
flushSync(() => {
14-
btn2.click();
15-
});
11+
flushSync(() => btn2.click());
1612
assert.deepEqual(logs, [[{}, {}, {}, {}, {}, {}, {}, {}], []]);
1713
}
1814
});

packages/svelte/tests/runtime-runes/samples/state-onchange-arrays/_config.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,19 +5,13 @@ export default test({
55
async test({ assert, target, logs }) {
66
const [btn, btn2, btn3] = target.querySelectorAll('button');
77

8-
flushSync(() => {
9-
btn.click();
10-
});
8+
flushSync(() => btn.click());
119
assert.deepEqual(logs, ['arr']);
1210

13-
flushSync(() => {
14-
btn2.click();
15-
});
11+
flushSync(() => btn2.click());
1612
assert.deepEqual(logs, ['arr', 'arr']);
1713

18-
flushSync(() => {
19-
btn3.click();
20-
});
14+
flushSync(() => btn3.click());
2115
assert.deepEqual(logs, ['arr', 'arr', 'arr']);
2216
}
2317
});

packages/svelte/tests/runtime-runes/samples/state-onchange-classes/_config.js

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,13 @@ export default test({
99

1010
logs.length = 0;
1111

12-
flushSync(() => {
13-
btn.click();
14-
});
12+
flushSync(() => btn.click());
1513
assert.deepEqual(logs, ['class count']);
1614

17-
flushSync(() => {
18-
btn2.click();
19-
});
15+
flushSync(() => btn2.click());
2016
assert.deepEqual(logs, ['class count', 'class proxy']);
2117

22-
flushSync(() => {
23-
btn3.click();
24-
});
18+
flushSync(() => btn3.click());
2519
assert.deepEqual(logs, ['class count', 'class proxy', 'class proxy']);
2620
}
2721
});

packages/svelte/tests/runtime-runes/samples/state-onchange-extrapolated-reference/_config.js

Lines changed: 8 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,15 @@ export default test({
66
const [btn, btn2, btn3, btn4, btn5, btn6] = target.querySelectorAll('button');
77
logs.length = 0;
88

9-
flushSync(() => {
10-
btn.click();
11-
});
12-
flushSync(() => {
13-
btn2.click();
14-
});
15-
flushSync(() => {
16-
btn3.click();
17-
});
18-
flushSync(() => {
19-
btn4.click();
20-
});
21-
flushSync(() => {
22-
btn5.click();
23-
});
9+
flushSync(() => btn.click());
10+
flushSync(() => btn2.click());
11+
flushSync(() => btn3.click());
12+
flushSync(() => btn4.click());
13+
flushSync(() => btn5.click());
2414
assert.deepEqual(logs, []);
25-
flushSync(() => {
26-
btn6.click();
27-
});
28-
flushSync(() => {
29-
btn.click();
30-
});
15+
16+
flushSync(() => btn6.click());
17+
flushSync(() => btn.click());
3118
assert.deepEqual(logs, ['arr', 'arr']);
3219
}
3320
});

packages/svelte/tests/runtime-runes/samples/state-onchange-proxies/_config.js

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,10 @@ export default test({
55
async test({ assert, target, logs }) {
66
const [btn, btn2] = target.querySelectorAll('button');
77

8-
flushSync(() => {
9-
btn.click();
10-
});
8+
flushSync(() => btn.click());
119
assert.deepEqual(logs, ['proxy']);
1210

13-
flushSync(() => {
14-
btn2.click();
15-
});
11+
flushSync(() => btn2.click());
1612
assert.deepEqual(logs, ['proxy', 'proxy']);
1713
}
1814
});

packages/svelte/tests/runtime-runes/samples/state-onchange-reassign-proxy/_config.js

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,16 @@ export default test({
55
async test({ assert, target, logs }) {
66
const [btn, btn2, btn3, btn4] = target.querySelectorAll('button');
77

8-
flushSync(() => {
9-
btn.click();
10-
});
8+
flushSync(() => btn.click());
119
assert.deepEqual(logs, ['a']);
1210

13-
flushSync(() => {
14-
btn2.click();
15-
});
11+
flushSync(() => btn2.click());
1612
assert.deepEqual(logs, ['a', 'b', 'c']);
17-
flushSync(() => {
18-
btn3.click();
19-
});
13+
flushSync(() => btn3.click());
2014
assert.deepEqual(logs, ['a', 'b', 'c', 'b', 'c']);
21-
flushSync(() => {
22-
btn4.click();
23-
});
15+
flushSync(() => btn4.click());
2416
assert.deepEqual(logs, ['a', 'b', 'c', 'b', 'c', 'c']);
25-
flushSync(() => {
26-
btn2.click();
27-
});
17+
flushSync(() => btn2.click());
2818
assert.deepEqual(logs, ['a', 'b', 'c', 'b', 'c', 'c', 'b']);
2919
}
3020
});

packages/svelte/tests/runtime-runes/samples/state-onchange/_config.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,7 @@ export default test({
55
async test({ assert, target, logs }) {
66
const btn = target.querySelector('button');
77

8-
flushSync(() => {
9-
btn?.click();
10-
});
8+
flushSync(() => btn?.click());
119
assert.deepEqual(logs, ['count']);
1210
}
1311
});

packages/svelte/tests/runtime-runes/samples/state-raw-onchange/_config.js

Lines changed: 10 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -10,54 +10,34 @@ export default test({
1010

1111
logs.length = 0;
1212

13-
flushSync(() => {
14-
btn.click();
15-
});
13+
flushSync(() => btn.click());
1614
assert.deepEqual(logs, ['count']);
1715

18-
flushSync(() => {
19-
btn2.click();
20-
});
16+
flushSync(() => btn2.click());
2117
assert.deepEqual(logs, ['count']);
2218

23-
flushSync(() => {
24-
btn3.click();
25-
});
19+
flushSync(() => btn3.click());
2620
assert.deepEqual(logs, ['count', 'proxy']);
2721

28-
flushSync(() => {
29-
btn4.click();
30-
});
22+
flushSync(() => btn4.click());
3123
assert.deepEqual(logs, ['count', 'proxy', 'class count']);
3224

33-
flushSync(() => {
34-
btn5.click();
35-
});
25+
flushSync(() => btn5.click());
3626
assert.deepEqual(logs, ['count', 'proxy', 'class count']);
3727

38-
flushSync(() => {
39-
btn6.click();
40-
});
28+
flushSync(() => btn6.click());
4129
assert.deepEqual(logs, ['count', 'proxy', 'class count', 'class proxy']);
4230

43-
flushSync(() => {
44-
btn7.click();
45-
});
31+
flushSync(() => btn7.click());
4632
assert.deepEqual(logs, ['count', 'proxy', 'class count', 'class proxy']);
4733

48-
flushSync(() => {
49-
btn8.click();
50-
});
34+
flushSync(() => btn8.click());
5135
assert.deepEqual(logs, ['count', 'proxy', 'class count', 'class proxy']);
5236

53-
flushSync(() => {
54-
btn9.click();
55-
});
37+
flushSync(() => btn9.click());
5638
assert.deepEqual(logs, ['count', 'proxy', 'class count', 'class proxy']);
5739

58-
flushSync(() => {
59-
btn10.click();
60-
});
40+
flushSync(() => btn10.click());
6141
assert.deepEqual(logs, ['count', 'proxy', 'class count', 'class proxy', 'arr']);
6242
}
6343
});

0 commit comments

Comments
 (0)