Skip to content

Commit 14d7b26

Browse files
committed
fix: more robust url equality check at dev time
fixes #10021
1 parent a476e81 commit 14d7b26

File tree

2 files changed

+6
-9
lines changed

2 files changed

+6
-9
lines changed

.changeset/gentle-spies-happen.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"svelte": patch
3+
---
4+
5+
fix: more robust url equality check at dev time

packages/svelte/src/internal/client/render.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2295,22 +2295,14 @@ export function attr(dom, attribute, value) {
22952295
}
22962296
}
22972297

2298-
/** @type {HTMLAnchorElement | undefined} */
2299-
let src_url_equal_anchor;
2300-
23012298
/**
23022299
* @param {string} element_src
23032300
* @param {string} url
23042301
* @returns {boolean}
23052302
*/
23062303
function src_url_equal(element_src, url) {
23072304
if (element_src === url) return true;
2308-
if (!src_url_equal_anchor) {
2309-
src_url_equal_anchor = document.createElement('a');
2310-
}
2311-
// This is actually faster than doing URL(..).href
2312-
src_url_equal_anchor.href = url;
2313-
return element_src === src_url_equal_anchor.href;
2305+
return new URL(element_src, document.baseURI).href === new URL(url, document.baseURI).href;
23142306
}
23152307

23162308
/** @param {string} srcset */

0 commit comments

Comments
 (0)