tweaks

Author: Rich-Harris

.changeset/README.md

@@ -0,0 +1,8 @@
+# Changesets
+
+Hello and welcome! This folder has been automatically generated by `@changesets/cli`, a build tool that works
+with multi-package repos, or single-package repos to help you version and publish your code. You can
+find the full documentation for it [in our repository](https://github.com/changesets/changesets)
+
+We have a quick list of common questions to get you started engaging with this project in
+[our documentation](https://github.com/changesets/changesets/blob/main/docs/common-questions.md)

.changeset/config.json

@@ -0,0 +1,11 @@
+{
+	"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
+	"changelog": ["@svitejs/changesets-changelog-github-compact", { "repo": "sveltejs/svelte" }],
+	"commit": false,
+	"fixed": [],
+	"linked": [],
+	"access": "public",
+	"baseBranch": "main",
+	"bumpVersionsWithWorkspaceProtocolOnly": true,
+	"ignore": ["!(@sveltejs/*|svelte)"]
+}

.editorconfig

@@ -11,5 +11,5 @@ trim_trailing_whitespace = true
 [test/**/expected.css]
 insert_final_newline = false
 
-[{package.json,.travis.yml,.eslintrc.json}]
+[package.json]
 indent_style = space

.eslintignore

@@ -1,7 +1,7 @@
-------
+---
 Before filing an issue we'd appreciate it if you could take a moment to ensure
 there isn't already an open issue or pull-request.
------
+---
 
 If there's an existing issue, please add a :+1: reaction to the description of
 the issue. One way we prioritize issues is by the number of :+1: reactions on
@@ -23,7 +23,6 @@ as you can including the following.
 - Svelte version (Please check you can reproduce the issue with the latest release!)
 - Whether your project uses Webpack or Rollup
 
-- *Repeatable steps to reproduce the issue*
+- _Repeatable steps to reproduce the issue_
 
-Thanks for being part of Svelte!
--------
+## Thanks for being part of Svelte!

.eslintrc.js

@@ -1,6 +1,6 @@
 name: "\U0001F41E Bug report"
 description: Report an issue with Svelte
-labels: ["triage: bug"]
+labels: ['triage: bug']
 body:
   - type: markdown
     attributes:
@@ -26,7 +26,7 @@ body:
     id: logs
     attributes:
       label: Logs
-      description: "Please include browser console and server logs around the time this bug occurred. Optional if provided reproduction. Please try not to insert an image but copy paste the log text."
+      description: 'Please include browser console and server logs around the time this bug occurred. Optional if provided reproduction. Please try not to insert an image but copy paste the log text.'
       render: shell
   - type: textarea
     id: system-info

.github/ISSUE_TEMPLATE.md

@@ -1,4 +1,4 @@
-name: "Feature Request"
+name: 'Feature Request'
 description: Request a new Svelte feature
 labels: [enhancement]
 body:
@@ -22,13 +22,6 @@ body:
       placeholder: I would like to see...
     validations:
       required: true
-  - type: textarea
-    id: alternatives
-    attributes:
-      label: Alternatives considered
-      description: "Please provide a clear and concise description of any alternative solutions or features you've considered."
-    validations:
-      required: true
   - type: dropdown
     id: importance
     attributes:

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -1,8 +1,11 @@
 ### Before submitting the PR, please make sure you do the following
+
 - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
 - [ ] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`.
 - [ ] This message body should clearly illustrate what problems it solves.
 - [ ] Ideally, include a test that fails without this PR but passes with it.
+- [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`).
+
+### Tests and linting
 
-### Tests
--  [ ] Run the tests with `npm test` and lint the project with `npm run lint`
+- [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint`

.github/ISSUE_TEMPLATE/feature_request.yml

@@ -1,101 +1,76 @@
 name: CI
 on:
   push:
-    branches: [ master ]
+    branches: [main]
   pull_request:
 permissions:
   contents: read # to fetch code (actions/checkout)
+
+env:
+  # We only install Chromium manually
+  PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: '1'
+
 jobs:
-  Setup:
-    runs-on: ${{ matrix.os }}
-    strategy:
-      matrix:
-        os: [ubuntu-latest, windows-latest, macOS-latest]
-    steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
-        with:
-          node-version: 18
-          cache: npm
-      - run: npm install
-        env:
-          SKIP_PREPARE: true
-      - run: npm run build
-        env:
-          PUBLISH: true
-      - name: Upload build assets
-        id: upload-artifact
-        uses: actions/upload-artifact@v3
-        with:
-          name: build-assets
-          path: |
-            index.*
-            compiler.*
-            ssr.*
-            action/
-            animate/
-            easing/
-            internal/
-            motion/
-            store/
-            transition/
-            types/
   Tests:
-    needs: Setup
     runs-on: ${{ matrix.os }}
     timeout-minutes: 15
     strategy:
       matrix:
-        node-version: [8, 10, 12, 14, 16, 18]
-        os: [ubuntu-latest, windows-latest, macOS-latest]
+        include:
+          - node-version: 18
+            os: windows-latest
+          - node-version: 18
+            os: macOS-latest
+          - node-version: 18
+            os: ubuntu-latest
+          - node-version: 20
+            os: ubuntu-latest
+          - node-version: 22
+            os: ubuntu-latest
+
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node-version }}
-          cache: npm
-      - name: Download build assets
-        uses: actions/download-artifact@v3
-        id: download-artifact
-        with:
-          name: build-assets
-      - name: Get Node version ${{ runner.os }}
-        run: echo "NODE_VERSION=`node --version`" >> $GITHUB_ENV
-        if: runner.os != 'Windows'
-      - name: Get Node version ${{ runner.os }}
-        run: |
-          chcp 65001
-          echo ("NODE_VERSION=$(node --version)") >> $env:GITHUB_ENV
-        if: runner.os == 'Windows'
-      - run: npm install --save-dev puppeteer@13
-        if: ${{ runner.os == 'Linux' && (!startsWith(env.NODE_VERSION, 'v8.') && !startsWith(env.NODE_VERSION, 'v10.')) }}
-      - run: npm install
-        env:
-          SKIP_PREPARE: true
-      - run: npm run test:integration
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm playwright install chromium
+      - run: pnpm test
         env:
           CI: true
   Lint:
     runs-on: ubuntu-latest
     timeout-minutes: 5
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v4
         with:
-          cache: npm
-      - run: 'npm i && npm run lint'
-  Unit:
-    runs-on: ${{ matrix.os }}
-    timeout-minutes: 10
-    strategy:
-      matrix:
-        os: [ubuntu-latest, windows-latest, macOS-latest]
+          node-version: 18
+          cache: pnpm
+      - name: install
+        run: pnpm install --frozen-lockfile
+      - name: type check
+        run: pnpm check
+      - name: lint
+        if: (${{ success() }} || ${{ failure() }}) # ensures this step runs even if previous steps fail (avoids multiple runs uncovering different issues at different steps)
+        run: pnpm lint
+      - name: build and check generated types
+        if: (${{ success() }} || ${{ failure() }}) # ensures this step runs even if previous steps fail
+        run: pnpm build && { [ "`git status --porcelain=v1`" == "" ] || (echo "Generated types have changed — please regenerate types locally and commit the changes after you have reviewed them"; git diff; exit 1); }
+  Benchmarks:
+    runs-on: ubuntu-latest
+    timeout-minutes: 15
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+      - uses: actions/setup-node@v4
         with:
-          cache: npm
-      - run: npm install
+          node-version: 18
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm bench
         env:
-          SKIP_PREPARE: true
-      - run: npm run test:unit
+          CI: true