Skip to content

Commit 2cd81c7

Browse files
committed
notes to self
1 parent 16f4725 commit 2cd81c7

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

packages/svelte/src/internal/client/dom/elements/transitions.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,11 @@ export function transition(flags, element, get_fn, get_params) {
192192

193193
var inert = element.inert;
194194

195+
/**
196+
* The default overflow style, stashed so we can revert changes during the transition
197+
* that are necessary to work around a Safari <18 bug
198+
* TODO 6.0 remove this, if older versions of Safari have died out enough
199+
*/
195200
var overflow = element.style.overflow;
196201

197202
/** @type {Animation | undefined} */
@@ -386,6 +391,11 @@ function animate(element, options, counterpart, t2, on_finish) {
386391
var keyframes = [];
387392

388393
if (duration > 0) {
394+
/**
395+
* Whether or not the CSS includes `overflow: hidden`, in which case we need to
396+
* add it as an inline style to work around a Safari <18 bug
397+
* TODO 6.0 remove this, if possible
398+
*/
389399
var needs_overflow_hidden = false;
390400

391401
if (css) {

0 commit comments

Comments
 (0)