fix: make messages more consistent (#11643)

Author: Rich-Harris

.changeset/cyan-ducks-teach.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: make messages more consistent

packages/svelte/messages/compile-errors/template.md

@@ -174,7 +174,7 @@
 
 ## mixed_event_handler_syntaxes
 
-> Mixing old (on:%name%) and new syntaxes for event handling is not allowed. Use only the on%name% syntax.
+> Mixing old (on:%name%) and new syntaxes for event handling is not allowed. Use only the on%name% syntax
 
 ## node_invalid_placement
 
@@ -230,7 +230,7 @@
 
 ## slot_snippet_conflict
 
-> Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely.
+> Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely
 
 ## snippet_conflict
 

packages/svelte/messages/compile-warnings/a11y.md

@@ -20,7 +20,7 @@
 
 ## a11y_click_events_have_key_events
 
-> Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type="button">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.
+> Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type="button">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details
 
 ## a11y_distracting_elements
 
@@ -40,7 +40,7 @@
 
 ## a11y_img_redundant_alt
 
-> Screenreaders already announce `<img>` elements as an image.
+> Screenreaders already announce `<img>` elements as an image
 
 ## a11y_incorrect_aria_attribute_type
 
@@ -76,15 +76,15 @@
 
 ## a11y_interactive_supports_focus
 
-> Elements with the '%role%' interactive role must have a tabindex value.
+> Elements with the '%role%' interactive role must have a tabindex value
 
 ## a11y_invalid_attribute
 
 > '%href_value%' is not a valid %href_attribute% attribute
 
 ## a11y_label_has_associated_control
 
-> A form label must be associated with a control.
+> A form label must be associated with a control
 
 ## a11y_media_has_caption
 
@@ -120,7 +120,7 @@
 
 ## a11y_no_noninteractive_element_interactions
 
-> Non-interactive element `<%element%>` should not be assigned mouse or keyboard event listeners.
+> Non-interactive element `<%element%>` should not be assigned mouse or keyboard event listeners
 
 ## a11y_no_noninteractive_element_to_interactive_role
 

packages/svelte/messages/compile-warnings/template.md

@@ -32,8 +32,8 @@
 
 ## event_directive_deprecated
 
-> Using `on:%name%` to listen to the %name% event is deprecated. Use the event attribute `on%name%` instead.
+> Using `on:%name%` to listen to the %name% event is deprecated. Use the event attribute `on%name%` instead
 
 ## slot_element_deprecated
 
-> Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead.
+> Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead

packages/svelte/src/compiler/errors.js

@@ -928,13 +928,13 @@ export function let_directive_invalid_placement(node) {
 }
 
 /**
- * Mixing old (on:%name%) and new syntaxes for event handling is not allowed. Use only the on%name% syntax.
+ * Mixing old (on:%name%) and new syntaxes for event handling is not allowed. Use only the on%name% syntax
  * @param {null | number | NodeLike} node
  * @param {string} name
  * @returns {never}
  */
 export function mixed_event_handler_syntaxes(node, name) {
-	e(node, "mixed_event_handler_syntaxes", `Mixing old (on:${name}) and new syntaxes for event handling is not allowed. Use only the on${name} syntax.`);
+	e(node, "mixed_event_handler_syntaxes", `Mixing old (on:${name}) and new syntaxes for event handling is not allowed. Use only the on${name} syntax`);
 }
 
 /**
@@ -1059,12 +1059,12 @@ export function slot_element_invalid_name_default(node) {
 }
 
 /**
- * Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely.
+ * Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely
  * @param {null | number | NodeLike} node
  * @returns {never}
  */
 export function slot_snippet_conflict(node) {
-	e(node, "slot_snippet_conflict", "Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely.");
+	e(node, "slot_snippet_conflict", "Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely");
 }
 
 /**

packages/svelte/src/compiler/warnings.js

@@ -137,11 +137,11 @@ export function a11y_autofocus(node) {
 }
 
 /**
- * Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type="button">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.
+ * Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type="button">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details
  * @param {null | NodeLike} node
  */
 export function a11y_click_events_have_key_events(node) {
-	w(node, "a11y_click_events_have_key_events", "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.");
+	w(node, "a11y_click_events_have_key_events", "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details");
 }
 
 /**
@@ -179,11 +179,11 @@ export function a11y_hidden(node, name) {
 }
 
 /**
- * Screenreaders already announce `<img>` elements as an image.
+ * Screenreaders already announce `<img>` elements as an image
  * @param {null | NodeLike} node
  */
 export function a11y_img_redundant_alt(node) {
-	w(node, "a11y_img_redundant_alt", "Screenreaders already announce `<img>` elements as an image.");
+	w(node, "a11y_img_redundant_alt", "Screenreaders already announce `<img>` elements as an image");
 }
 
 /**
@@ -262,12 +262,12 @@ export function a11y_incorrect_aria_attribute_type_tristate(node, attribute) {
 }
 
 /**
- * Elements with the '%role%' interactive role must have a tabindex value.
+ * Elements with the '%role%' interactive role must have a tabindex value
  * @param {null | NodeLike} node
  * @param {string} role
  */
 export function a11y_interactive_supports_focus(node, role) {
-	w(node, "a11y_interactive_supports_focus", `Elements with the '${role}' interactive role must have a tabindex value.`);
+	w(node, "a11y_interactive_supports_focus", `Elements with the '${role}' interactive role must have a tabindex value`);
 }
 
 /**
@@ -281,11 +281,11 @@ export function a11y_invalid_attribute(node, href_value, href_attribute) {
 }
 
 /**
- * A form label must be associated with a control.
+ * A form label must be associated with a control
  * @param {null | NodeLike} node
  */
 export function a11y_label_has_associated_control(node) {
-	w(node, "a11y_label_has_associated_control", "A form label must be associated with a control.");
+	w(node, "a11y_label_has_associated_control", "A form label must be associated with a control");
 }
 
 /**
@@ -363,12 +363,12 @@ export function a11y_no_interactive_element_to_noninteractive_role(node, element
 }
 
 /**
- * Non-interactive element `<%element%>` should not be assigned mouse or keyboard event listeners.
+ * Non-interactive element `<%element%>` should not be assigned mouse or keyboard event listeners
  * @param {null | NodeLike} node
  * @param {string} element
  */
 export function a11y_no_noninteractive_element_interactions(node, element) {
-	w(node, "a11y_no_noninteractive_element_interactions", `Non-interactive element \`<${element}>\` should not be assigned mouse or keyboard event listeners.`);
+	w(node, "a11y_no_noninteractive_element_interactions", `Non-interactive element \`<${element}>\` should not be assigned mouse or keyboard event listeners`);
 }
 
 /**
@@ -698,18 +698,18 @@ export function element_invalid_self_closing_tag(node, name) {
 }
 
 /**
- * Using `on:%name%` to listen to the %name% event is deprecated. Use the event attribute `on%name%` instead.
+ * Using `on:%name%` to listen to the %name% event is deprecated. Use the event attribute `on%name%` instead
  * @param {null | NodeLike} node
  * @param {string} name
  */
 export function event_directive_deprecated(node, name) {
-	w(node, "event_directive_deprecated", `Using \`on:${name}\` to listen to the ${name} event is deprecated. Use the event attribute \`on${name}\` instead.`);
+	w(node, "event_directive_deprecated", `Using \`on:${name}\` to listen to the ${name} event is deprecated. Use the event attribute \`on${name}\` instead`);
 }
 
 /**
- * Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead.
+ * Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead
  * @param {null | NodeLike} node
  */
 export function slot_element_deprecated(node) {
-	w(node, "slot_element_deprecated", "Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead.");
+	w(node, "slot_element_deprecated", "Using `<slot>` to render parent content is deprecated. Use `{@render ...}` tags instead");
 }

packages/svelte/tests/compiler-errors/samples/slot-conflicting-with-render-tag/_config.js

@@ -4,7 +4,7 @@ export default test({
 	error: {
 		code: 'slot_snippet_conflict',
 		message:
-			'Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely.',
+			'Cannot use `<slot>` syntax and `{@render ...}` tags in the same component. Migrate towards `{@render ...}` tags completely',
 		position: [71, 84]
 	}
 });

packages/svelte/tests/validator/samples/a11y-click-events-have-key-events/warnings.json

@@ -1,7 +1,7 @@
 [
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 13,
 			"column": 0
@@ -13,7 +13,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 15,
 			"column": 0
@@ -25,7 +25,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 18,
 			"column": 0
@@ -37,7 +37,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 20,
 			"column": 0
@@ -49,7 +49,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 22,
 			"column": 0
@@ -61,7 +61,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 24,
 			"column": 0
@@ -73,7 +73,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 26,
 			"column": 0
@@ -85,7 +85,7 @@
 	},
 	{
 		"code": "a11y_click_events_have_key_events",
-		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details.",
+		"message": "Visible, non-interactive elements with a click event must be accompanied by a keyboard event handler. Consider whether an interactive element such as `<button type=\"button\">` or `<a>` might be more appropriate. See https://svelte.dev/docs/accessibility-warnings#a11y-click-events-have-key-events for more details",
 		"start": {
 			"line": 28,
 			"column": 0

packages/svelte/tests/validator/samples/a11y-img-redundant-alt/warnings.json

@@ -1,7 +1,7 @@
 [
 	{
 		"code": "a11y_img_redundant_alt",
-		"message": "Screenreaders already announce `<img>` elements as an image.",
+		"message": "Screenreaders already announce `<img>` elements as an image",
 		"end": {
 			"column": 49,
 			"line": 3
@@ -13,7 +13,7 @@
 	},
 	{
 		"code": "a11y_img_redundant_alt",
-		"message": "Screenreaders already announce `<img>` elements as an image.",
+		"message": "Screenreaders already announce `<img>` elements as an image",
 		"end": {
 			"column": 45,
 			"line": 4
@@ -25,7 +25,7 @@
 	},
 	{
 		"code": "a11y_img_redundant_alt",
-		"message": "Screenreaders already announce `<img>` elements as an image.",
+		"message": "Screenreaders already announce `<img>` elements as an image",
 		"end": {
 			"column": 52,
 			"line": 5