chore: always queue removing let directives

Author: paoloricciuti

packages/svelte/src/compiler/migrate/index.js

@@ -1100,7 +1100,6 @@ function migrate_slot_usage(node, path, state) {
 	// if we stop the transform because the name is not correct we don't want to
 	// remove the let directive and they could come before the name
 	let removal_queue = [];
-	let slot_name_found = false;
 
 	for (let attribute of node.attributes) {
 		if (
@@ -1130,7 +1129,6 @@ function migrate_slot_usage(node, path, state) {
 					}
 				}
 			}
-			slot_name_found = true;
 			// flush the queue after we found the name
 			for (let remove_let of removal_queue) {
 				remove_let();
@@ -1144,19 +1142,12 @@ function migrate_slot_usage(node, path, state) {
 						? `: ${state.str.original.substring(/** @type {number} */ (attribute.expression.start), /** @type {number} */ (attribute.expression.end))}`
 						: '')
 			);
-			function remove_let() {
-				state.str.remove(attribute.start, attribute.end);
-			}
-			// if we didn't find the name yet we just add to the queue else we call immediately
-			if (slot_name_found) {
-				remove_let();
-			} else {
-				removal_queue.push(remove_let);
-			}
+			// we just add to the queue to remove them after we found if we need to migrate or we bail
+			removal_queue.push(() => state.str.remove(attribute.start, attribute.end));
 		}
 	}
 
-	if (!slot_name_found && removal_queue.length > 0) {
+	if (removal_queue.length > 0) {
 		for (let remove_let of removal_queue) {
 			remove_let();
 		}