Skip to content

Commit 3e3d20c

Browse files
committed
tweak
1 parent d387f79 commit 3e3d20c

File tree

9 files changed

+22
-18
lines changed

9 files changed

+22
-18
lines changed

packages/svelte/src/compiler/phases/3-transform/client/visitors/AwaitBlock.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { extract_identifiers } from '../../../../utils/ast.js';
55
import * as b from '#compiler/builders';
66
import { create_derived } from '../utils.js';
77
import { get_value } from './shared/declarations.js';
8-
import { build_expression, with_dev_stack } from './shared/utils.js';
8+
import { build_expression, add_svelte_meta } from './shared/utils.js';
99

1010
/**
1111
* @param {AST.AwaitBlock} node
@@ -54,7 +54,7 @@ export function AwaitBlock(node, context) {
5454
}
5555

5656
context.state.init.push(
57-
with_dev_stack(
57+
add_svelte_meta(
5858
b.call(
5959
'$.await',
6060
context.state.node,

packages/svelte/src/compiler/phases/3-transform/client/visitors/EachBlock.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { dev } from '../../../../state.js';
1313
import { extract_paths, object } from '../../../../utils/ast.js';
1414
import * as b from '#compiler/builders';
1515
import { get_value } from './shared/declarations.js';
16-
import { build_expression, with_dev_stack } from './shared/utils.js';
16+
import { build_expression, add_svelte_meta } from './shared/utils.js';
1717

1818
/**
1919
* @param {AST.EachBlock} node
@@ -337,7 +337,7 @@ export function EachBlock(node, context) {
337337
);
338338
}
339339

340-
context.state.init.push(with_dev_stack(b.call('$.each', ...args), node, 'each'));
340+
context.state.init.push(add_svelte_meta(b.call('$.each', ...args), node, 'each'));
341341
}
342342

343343
/**

packages/svelte/src/compiler/phases/3-transform/client/visitors/IfBlock.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/** @import { AST } from '#compiler' */
33
/** @import { ComponentContext } from '../types' */
44
import * as b from '#compiler/builders';
5-
import { build_expression, with_dev_stack } from './shared/utils.js';
5+
import { build_expression, add_svelte_meta } from './shared/utils.js';
66

77
/**
88
* @param {AST.IfBlock} node
@@ -74,7 +74,7 @@ export function IfBlock(node, context) {
7474
args.push(b.id('$$elseif'));
7575
}
7676

77-
statements.push(with_dev_stack(b.call('$.if', ...args), node, 'if'));
77+
statements.push(add_svelte_meta(b.call('$.if', ...args), node, 'if'));
7878

7979
context.state.init.push(b.block(statements));
8080
}

packages/svelte/src/compiler/phases/3-transform/client/visitors/KeyBlock.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/** @import { AST } from '#compiler' */
33
/** @import { ComponentContext } from '../types' */
44
import * as b from '#compiler/builders';
5-
import { build_expression, with_dev_stack } from './shared/utils.js';
5+
import { build_expression, add_svelte_meta } from './shared/utils.js';
66

77
/**
88
* @param {AST.KeyBlock} node
@@ -15,7 +15,7 @@ export function KeyBlock(node, context) {
1515
const body = /** @type {Expression} */ (context.visit(node.fragment));
1616

1717
context.state.init.push(
18-
with_dev_stack(
18+
add_svelte_meta(
1919
b.call('$.key', context.state.node, b.thunk(key), b.arrow([b.id('$$anchor')], body)),
2020
node,
2121
'key'

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/component.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
build_bind_this,
99
memoize_expression,
1010
validate_binding,
11-
with_dev_stack
11+
add_svelte_meta
1212
} from '../shared/utils.js';
1313
import { build_attribute_value } from '../shared/element.js';
1414
import { build_event_handler } from './events.js';
@@ -490,7 +490,7 @@ export function build_component(node, component_name, context) {
490490
context.state.template.push_comment();
491491

492492
statements.push(
493-
with_dev_stack(fn(anchor), node, 'component', { componentTag: component_name })
493+
add_svelte_meta(fn(anchor), node, 'component', { componentTag: component_name })
494494
);
495495
}
496496

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import * as b from '#compiler/builders';
77
import { sanitize_template_string } from '../../../../../utils/sanitize_template_string.js';
88
import { regex_is_valid_identifier } from '../../../../patterns.js';
99
import is_reference from 'is-reference';
10-
import { dev, is_ignored, locator, filename } from '../../../../../state.js';
10+
import { dev, is_ignored, locator, component_name } from '../../../../../state.js';
1111
import { build_getter, create_derived } from '../../utils.js';
1212

1313
/**
@@ -403,7 +403,7 @@ export function build_expression(context, expression, metadata, state = context.
403403
* @param {Record<string, number | string>} [additional] - Any additional properties to add to the dev stack entry
404404
* @returns {Statement} - Statement with or without dev stack wrapping
405405
*/
406-
export function with_dev_stack(call_expression, node, type, additional) {
406+
export function add_svelte_meta(call_expression, node, type, additional) {
407407
if (!dev) {
408408
return b.stmt(call_expression);
409409
}
@@ -415,10 +415,10 @@ export function with_dev_stack(call_expression, node, type, additional) {
415415

416416
return b.stmt(
417417
b.call(
418-
'$.with_dev_stack',
418+
'$.add_svelte_meta',
419419
b.arrow([], call_expression),
420420
b.literal(type),
421-
b.literal(filename),
421+
b.id(component_name),
422422
b.literal(location.line),
423423
b.literal(location.column),
424424
additional && b.object(Object.entries(additional).map(([k, v]) => b.init(k, b.literal(v))))

packages/svelte/src/compiler/state.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ export let warnings = [];
1616
*/
1717
export let filename;
1818

19+
/**
20+
* The name of the component that is used in the `export default function ...` statement.
21+
*/
1922
export let component_name = '<unknown>';
2023

2124
/**

packages/svelte/src/internal/client/context.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import {
1111
} from './runtime.js';
1212
import { effect, teardown } from './reactivity/effects.js';
1313
import { legacy_mode_flag } from '../flags/index.js';
14+
import { FILENAME } from '../../constants.js';
1415

1516
/** @type {ComponentContext | null} */
1617
export let component_context = null;
@@ -32,18 +33,18 @@ export function set_dev_stack(stack) {
3233
* Execute a callback with a new dev stack entry
3334
* @param {() => any} callback - Function to execute
3435
* @param {DevStackEntry['type']} type - Type of block/component
35-
* @param {string} file - Source file
36+
* @param {any} component - Component function
3637
* @param {number} line - Line number
3738
* @param {number} column - Column number
3839
* @param {Record<string, any>} [additional] - Any additional properties to add to the dev stack entry
3940
* @returns {any}
4041
*/
41-
export function with_dev_stack(callback, type, file, line, column, additional) {
42+
export function add_svelte_meta(callback, type, component, line, column, additional) {
4243
const parent = dev_stack;
4344

4445
dev_stack = {
4546
type,
46-
file,
47+
file: component[FILENAME],
4748
line,
4849
column,
4950
parent,

packages/svelte/src/internal/client/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
export { createAttachmentKey as attachment } from '../../attachments/index.js';
22
export { FILENAME, HMR, NAMESPACE_SVG } from '../../constants.js';
3-
export { push, pop, with_dev_stack } from './context.js';
3+
export { push, pop, add_svelte_meta } from './context.js';
44
export { assign, assign_and, assign_or, assign_nullish } from './dev/assign.js';
55
export { cleanup_styles } from './dev/css.js';
66
export { add_locations } from './dev/elements.js';

0 commit comments

Comments
 (0)