Skip to content

Commit 43679b8

Browse files
authored
fix: A few type adjustments (#12858)
* crossorigin is an enumerated type * wrap is an enumerated type * changeset
1 parent 74b6f4d commit 43679b8

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

.changeset/six-vans-add.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: stricter `crossorigin` and `wrap` attributes types

packages/svelte/elements.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1091,7 +1091,7 @@ export interface HTMLLiAttributes extends HTMLAttributes<HTMLLIElement> {
10911091

10921092
export interface HTMLLinkAttributes extends HTMLAttributes<HTMLLinkElement> {
10931093
as?: string | undefined | null;
1094-
crossorigin?: string | undefined | null;
1094+
crossorigin?: 'anonymous' | 'use-credentials' | '' | undefined | null;
10951095
href?: string | undefined | null;
10961096
hreflang?: string | undefined | null;
10971097
integrity?: string | undefined | null;
@@ -1125,7 +1125,7 @@ export interface HTMLMediaAttributes<T extends HTMLMediaElement> extends HTMLAtt
11251125
| (string & {})
11261126
| undefined
11271127
| null;
1128-
crossorigin?: string | undefined | null;
1128+
crossorigin?: 'anonymous' | 'use-credentials' | '' | undefined | null;
11291129
currenttime?: number | undefined | null;
11301130
defaultmuted?: boolean | undefined | null;
11311131
defaultplaybackrate?: number | undefined | null;
@@ -1236,7 +1236,7 @@ export interface HTMLScriptAttributes extends HTMLAttributes<HTMLScriptElement>
12361236
async?: boolean | undefined | null;
12371237
/** @deprecated */
12381238
charset?: string | undefined | null;
1239-
crossorigin?: string | undefined | null;
1239+
crossorigin?: 'anonymous' | 'use-credentials' | '' | undefined | null;
12401240
defer?: boolean | undefined | null;
12411241
fetchpriority?: 'auto' | 'high' | 'low' | undefined | null;
12421242
integrity?: string | undefined | null;
@@ -1306,7 +1306,7 @@ export interface HTMLTextareaAttributes extends HTMLAttributes<HTMLTextAreaEleme
13061306
required?: boolean | undefined | null;
13071307
rows?: number | undefined | null;
13081308
value?: string | string[] | number | undefined | null;
1309-
wrap?: string | undefined | null;
1309+
wrap?: 'hard' | 'soft' | undefined | null;
13101310

13111311
'on:change'?: ChangeEventHandler<HTMLTextAreaElement> | undefined | null;
13121312
onchange?: ChangeEventHandler<HTMLTextAreaElement> | undefined | null;

0 commit comments

Comments
 (0)