more bug fixes

Author: trueadm

packages/svelte/src/internal/client/dom/blocks/boundary.js

@@ -66,14 +66,6 @@ export function boundary(node, boundary_fn, props) {
 			var onerror = props.onerror;
 			let failed_snippet = props.failed;
 
-			if (boundary_effect) {
-				destroy_effect(boundary_effect);
-			} else if (hydrating) {
-				set_hydrate_node(hydrate_open);
-				next();
-				set_hydrate_node(remove_nodes());
-			}
-
 			// If we have nothing to capture the error then re-throw the error
 			// for another boundary to handle, additionaly, if we're creating
 			// the fallback and that too fails, then re-throw the error
@@ -98,6 +90,14 @@ export function boundary(node, boundary_fn, props) {
 				onerror(error, reset);
 			}
 
+			if (boundary_effect) {
+				destroy_effect(boundary_effect);
+			} else if (hydrating) {
+				set_hydrate_node(hydrate_open);
+				next();
+				set_hydrate_node(remove_nodes());
+			}
+
 			// Handle the `failed` snippet fallback
 			if (failed_snippet) {
 				// Ensure we create the boundary branch after the catch event cycle finishes

packages/svelte/src/internal/client/reactivity/effects.js

@@ -464,12 +464,12 @@ export function destroy_effect(effect, remove_dom = true) {
 	}
 
 	// `first` and `child` are nulled out in destroy_effect_children
+	// we don't null out `parent` so that error propagation can work correctly
 	effect.next =
 		effect.prev =
 		effect.teardown =
 		effect.ctx =
 		effect.deps =
-		effect.parent =
 		effect.fn =
 		effect.nodes_start =
 		effect.nodes_end =

packages/svelte/src/internal/client/runtime.js

@@ -669,6 +669,7 @@ function process_effects(effect, collected_effects) {
 		var flags = current_effect.f;
 		var is_branch = (flags & BRANCH_EFFECT) !== 0;
 		var is_skippable_branch = is_branch && (flags & CLEAN) !== 0;
+		var sibling = current_effect.next;
 
 		if (!is_skippable_branch && (flags & INERT) === 0) {
 			if ((flags & RENDER_EFFECT) !== 0) {
@@ -695,8 +696,6 @@ function process_effects(effect, collected_effects) {
 			}
 		}
 
-		var sibling = current_effect.next;
-
 		if (sibling === null) {
 			let parent = current_effect.parent;
 

packages/svelte/tests/runtime-runes/samples/error-boundary-18/_config.js

@@ -0,0 +1,15 @@
+import { flushSync } from 'svelte';
+import { test } from '../../test';
+
+export default test({
+	test({ assert, target }) {
+		let btn = target.querySelector('button');
+
+		btn?.click();
+		btn?.click();
+
+		assert.throws(() => {
+			flushSync();
+		}, /test\n\n\tin {expression}\n/);
+	}
+});

packages/svelte/tests/runtime-runes/samples/error-boundary-18/main.svelte

@@ -0,0 +1,16 @@
+<script>
+	let count = $state(0);
+
+	let test = $derived.by(() => {
+		if (count > 1) {
+			throw new Error('test');
+		}
+	});
+</script>
+
+<svelte:boundary onerror={(e) => { throw(e) }}>
+		<div>Count: {count}</div>
+		<button onclick={() => count++}>Increment</button>
+		{count} / {test}
+</svelte:boundary>
+

packages/svelte/tests/runtime-runes/samples/error-boundary-19/_config.js

@@ -0,0 +1,14 @@
+import { flushSync } from 'svelte';
+import { test } from '../../test';
+
+export default test({
+	test({ assert, target, logs }) {
+		let btn = target.querySelector('button');
+
+		btn?.click();
+		btn?.click();
+		flushSync();
+
+		assert.deepEqual(logs, ['error caught 1', 'error caught 2']);
+	}
+});

packages/svelte/tests/runtime-runes/samples/error-boundary-19/main.svelte

@@ -0,0 +1,22 @@
+<script>
+	let count = $state(0);
+
+	let test = $derived.by(() => {
+		if (count > 1) {
+			throw new Error('test');
+		}
+	});
+</script>
+
+<svelte:boundary onerror={(e) => {console.log('error caught 1')}}>
+		<div>Count: {count}</div>
+		<button onclick={() => count++}>Increment</button>
+		{count} / {test}
+</svelte:boundary>
+
+
+<svelte:boundary onerror={(e) => {console.log('error caught 2')}}>
+		<div>Count: {count}</div>
+		<button onclick={() => count++}>Increment</button>
+		{count} / {test}
+</svelte:boundary>