complete redesign

Author: trueadm

packages/svelte/src/compiler/phases/3-transform/client/transform-client.js

@@ -17,7 +17,6 @@ import { BindDirective } from './visitors/BindDirective.js';
 import { BlockStatement } from './visitors/BlockStatement.js';
 import { BreakStatement } from './visitors/BreakStatement.js';
 import { CallExpression } from './visitors/CallExpression.js';
-import { NewExpression } from './visitors/NewExpression.js';
 import { ClassBody } from './visitors/ClassBody.js';
 import { Comment } from './visitors/Comment.js';
 import { Component } from './visitors/Component.js';
@@ -92,7 +91,6 @@ const visitors = {
 	BlockStatement,
 	BreakStatement,
 	CallExpression,
-	NewExpression,
 	ClassBody,
 	Comment,
 	Component,

packages/svelte/src/compiler/phases/3-transform/client/utils.js

@@ -14,7 +14,6 @@ import {
 } from '../../../../constants.js';
 import { dev } from '../../../state.js';
 import { get_value } from './visitors/shared/declarations.js';
-import { walk } from 'zimmerframe';
 
 /**
  * @param {Binding} binding
@@ -352,61 +351,3 @@ export function is_inlinable_expression(node_or_nodes, state) {
 	}
 	return has_expression_tag;
 }
-
-/**
- * @param {Expression} node
- * @param {Expression} expression
- * @param {ClientTransformState} state
- */
-export function trace(node, expression, state) {
-	const loc = node.loc;
-	const source = state.source;
-	let code = '';
-	let bailout = false;
-
-	walk(expression, null, {
-		AwaitExpression() {
-			bailout = true;
-		}
-	});
-
-	if (bailout) {
-		return expression;
-	}
-
-	if (loc) {
-		const start = loc.start;
-		const end = loc.end;
-
-		if (start.line === end.line) {
-			code = source[start.line - 1].slice(start.column, end.column);
-		} else {
-			for (let i = start.line; i < end.line + 1; i++) {
-				const loc = source[i - 1];
-
-				if (i === start.line) {
-					code += loc.slice(start.column) + '\n';
-				} else if (i === end.line) {
-					code += loc.slice(0, end.column);
-				} else {
-					code += loc + '\n';
-				}
-			}
-		}
-	} else if (node.start !== undefined && node.end !== undefined) {
-		code = source.join('\n').slice(node.start, node.end);
-	} else {
-		return expression;
-	}
-
-	return b.call(
-		'$.trace',
-		b.thunk(expression),
-		b.literal(code),
-		node.type === 'CallExpression' ||
-			node.type === 'MemberExpression' ||
-			node.type === 'NewExpression'
-			? b.literal(true)
-			: undefined
-	);
-}

packages/svelte/src/compiler/phases/3-transform/client/visitors/BlockStatement.js

@@ -15,7 +15,7 @@ export function BlockStatement(node, context) {
 		return b.block([
 			b.return(
 				b.call(
-					'$.log_trace',
+					'$.trace',
 					b.thunk(
 						b.block(
 							node.body.map(

packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js

@@ -4,7 +4,6 @@ import { dev, is_ignored } from '../../../../state.js';
 import * as b from '../../../../utils/builders.js';
 import { get_rune } from '../../../scope.js';
 import { transform_inspect_rune } from '../../utils.js';
-import { trace } from '../utils.js';
 
 /**
  * @param {CallExpression} node
@@ -62,17 +61,5 @@ export function CallExpression(node, context) {
 		);
 	}
 
-	if (dev) {
-		return trace(
-			node,
-			{
-				...node,
-				callee: /** @type {Expression} */ (context.visit(node.callee)),
-				arguments: node.arguments.map((arg) => /** @type {Expression} */ (context.visit(arg)))
-			},
-			context.state
-		);
-	}
-
 	context.next();
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/Identifier.js

@@ -2,16 +2,14 @@
 /** @import { Context } from '../types' */
 import is_reference from 'is-reference';
 import * as b from '../../../../utils/builders.js';
-import { build_getter, trace } from '../utils.js';
-import { dev } from '../../../../state.js';
+import { build_getter } from '../utils.js';
 
 /**
  * @param {Identifier} node
  * @param {Context} context
  */
 export function Identifier(node, context) {
 	const parent = /** @type {Node} */ (context.path.at(-1));
-	let transformed;
 
 	if (is_reference(node, parent)) {
 		if (node.name === '$$props') {
@@ -34,18 +32,10 @@ export function Identifier(node, context) {
 				grand_parent?.type !== 'AssignmentExpression' &&
 				grand_parent?.type !== 'UpdateExpression'
 			) {
-				transformed = b.id('$$props');
+				return b.id('$$props');
 			}
 		}
 
-		if (!transformed) {
-			transformed = build_getter(node, context.state);
-		}
-	}
-
-	if (transformed && transformed !== node && dev) {
-		return trace(node, transformed, context.state);
+		return build_getter(node, context.state);
 	}
-
-	return transformed;
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/MemberExpression.js

@@ -1,47 +1,19 @@
 /** @import { MemberExpression, Expression, Super, PrivateIdentifier } from 'estree' */
 /** @import { Context } from '../types' */
-import { dev } from '../../../../state.js';
 import * as b from '../../../../utils/builders.js';
-import { trace } from '../utils.js';
 
 /**
  * @param {MemberExpression} node
  * @param {Context} context
  */
 export function MemberExpression(node, context) {
-	let transformed;
 	// rewrite `this.#foo` as `this.#foo.v` inside a constructor
 	if (node.property.type === 'PrivateIdentifier') {
 		const field = context.state.private_state.get(node.property.name);
 		if (field) {
-			transformed = context.state.in_constructor ? b.member(node, 'v') : b.call('$.get', node);
+			return context.state.in_constructor ? b.member(node, 'v') : b.call('$.get', node);
 		}
 	}
 
-	const parent = context.path.at(-1);
-
-	if (
-		dev &&
-		// Bail out of tracing members if they're used as calees to avoid context issues
-		(parent?.type !== 'CallExpression' || parent.callee !== node) &&
-		parent?.type !== 'BindDirective' &&
-		parent?.type !== 'AssignmentExpression' &&
-		parent?.type !== 'UpdateExpression' &&
-		parent?.type !== 'Component' &&
-		!node.optional
-	) {
-		return trace(
-			node,
-			transformed || {
-				...node,
-				object: /** @type {Expression | Super} */ (context.visit(node.object)),
-				property: /** @type {Expression | PrivateIdentifier} */ (context.visit(node.property))
-			},
-			context.state
-		);
-	} else if (transformed) {
-		return transformed;
-	}
-
 	context.next();
 }